change default cassandra jmx name

Author: JuniusLuo

catalog/cassandra/README.md

@@ -24,16 +24,16 @@ firecamp-service-cli -op=scale-service -service-type=cassandra -region=us-east-1
 
 3. Use [nodetool status](https://docs.datastax.com/en/cassandra/3.0/cassandra/tools/toolsStatus.html) to verify the new replicas are fully bootstrapped and all other nodes are up (UN).
 ```
-nodetool -h mycas-3.t1-firecamp.com -u cassandrajmx -pw changeme status
-nodetool -h mycas-4.t1-firecamp.com -u cassandrajmx -pw changeme status
-nodetool -h mycas-5.t1-firecamp.com -u cassandrajmx -pw changeme status
+nodetool -h mycas-3.t1-firecamp.com -u jmxuser -pw changeme status
+nodetool -h mycas-4.t1-firecamp.com -u jmxuser -pw changeme status
+nodetool -h mycas-5.t1-firecamp.com -u jmxuser -pw changeme status
 ```
 
 4. Run [nodetool cleanup](https://docs.datastax.com/en/cassandra/3.0/cassandra/tools/toolsCleanup.html) on each of the previously existing nodes to remove the keys that no longer belong to those nodes. Wait for cleanup to complete on one node before running nodetool cleanup on the next node. Cleanup can be safely postponed for low-usage hours.
 ```
-nodetool -h mycas-0.t1-firecamp.com -u cassandrajmx -pw changeme cleanup
-nodetool -h mycas-1.t1-firecamp.com -u cassandrajmx -pw changeme cleanup
-nodetool -h mycas-2.t1-firecamp.com -u cassandrajmx -pw changeme cleanup
+nodetool -h mycas-0.t1-firecamp.com -u jmxuser -pw changeme cleanup
+nodetool -h mycas-1.t1-firecamp.com -u jmxuser -pw changeme cleanup
+nodetool -h mycas-2.t1-firecamp.com -u jmxuser -pw changeme cleanup
 ```
 
 Currently FireCamp only supports scaling from 3 replicas. Scaling from 1 replica is not supported yet. Scaling down the replicas are not supported as well. If you want to stop the service when idle, could run `firecamp-service-cli -op=stop-service -service-name=mycas`. This will stop the service containers, while the volumes are still there. Later could start the containers with `firecamp-service-cli -op=start-service -service-name=mycas`.
@@ -87,7 +87,7 @@ The Cassandra logs are sent to the Cloud Logs, such as AWS CloudWatch logs.
 
 **[JMX](https://docs.datastax.com/en/cassandra/3.0/cassandra/configuration/secureJmxAuthentication.html)**
 
-By default, JMX is enabled to allow tools such as nodetool to access the Cassandra replica remotely. You could specify the JMX user and password when creating the service. If you do not specify the JMX user and password, the default user is "cassandrajmx" and an UUID will be generated as the password.
+By default, JMX is enabled to allow tools such as nodetool to access the Cassandra replica remotely. You could specify the JMX user and password when creating the service. If you do not specify the JMX user and password, the default user is "jmxuser" and an UUID will be generated as the password.
 
 **[JVM Configs](https://docs.datastax.com/en/cassandra/2.1/cassandra/operations/ops_tune_jvm_c.html)**
 
@@ -135,9 +135,9 @@ In case the service creation fails, please simply retry it. Once the service is
 
 ## Check Cassandra service status
 
-The Cassandra service creation will return the cassandra jmx password, such as `2018-02-11 21:13:10.524442554 +0000 UTC The catalog service is created, jmx user cassandrajmx password 9ba31d4787504894638611e0aeb91c93`.
+The Cassandra service creation will return the cassandra jmx password, such as `2018-02-11 21:13:10.524442554 +0000 UTC The catalog service is created, jmx user jmxuser password 9ba31d4787504894638611e0aeb91c93`.
 
-To double check Cassandra is successfully initialized and includes all replicas, run `nodetool -h mycas-0.t1-firecamp.com -u cassandrajmx -pw 9ba31d4787504894638611e0aeb91c93 status`. It should include all replicas. In case, if some replica is not included, for example, you create a 6 replicas Cassandra service, but nodetool shows only 5 members, use firecamp-service-cli to stop the services, `firecamp-service-cli -region=us-east-1 -cluster=t1 -op=stop-service -service-name=mycas`, and start again with `firecamp-service-cli -region=us-east-1 -cluster=t1 -op=start-service -service-name=mycas`. Then check with nodetool again.
+To double check Cassandra is successfully initialized and includes all replicas, run `nodetool -h mycas-0.t1-firecamp.com -u jmxuser -pw 9ba31d4787504894638611e0aeb91c93 status`. It should include all replicas. In case, if some replica is not included, for example, you create a 6 replicas Cassandra service, but nodetool shows only 5 members, use firecamp-service-cli to stop the services, `firecamp-service-cli -region=us-east-1 -cluster=t1 -op=stop-service -service-name=mycas`, and start again with `firecamp-service-cli -region=us-east-1 -cluster=t1 -op=start-service -service-name=mycas`. Then check with nodetool again.
 
 ## Create the New Super User
 Cassandra has a default super user, name "cassandra" and password "cassandra". After the Cassandra service is initialized, please login to create a new superuser and disable the default "cassandra" superuser. The steps are:

catalog/cassandra/cascatalog.go

@@ -29,22 +29,18 @@ const (
 	MaxHeapMB = 14 * 1024
 	// MinHeapMB is the minimal JVM heap size. If heap < 1024, jvm may stall long time at gc.
 	MinHeapMB = 1024
-	// DefaultJmxRemoteUser is the default jmx remote user.
-	DefaultJmxRemoteUser = "cassandrajmx"
 
 	intraNodePort    = 7000
 	tlsIntraNodePort = 7001
 	jmxPort          = 7199
 	cqlPort          = 9042
 	thriftPort       = 9160
 
-	yamlConfFileName            = "cassandra.yaml"
-	rackdcConfFileName          = "cassandra-rackdc.properties"
-	jvmConfFileName             = "jvm.options"
-	logConfFileName             = "logback.xml"
-	jmxRemotePasswdConfFileName = "jmxremote.password"
-
-	jmxRemotePasswdConfFileMode = 0400
+	yamlConfFileName   = "cassandra.yaml"
+	rackdcConfFileName = "cassandra-rackdc.properties"
+	jvmConfFileName    = "jvm.options"
+	logConfFileName    = "logback.xml"
+	// jmx file is defined in catalog/types.go
 )
 
 // The default Cassandra catalog service. By default,
@@ -85,7 +81,7 @@ func GenDefaultCreateServiceRequest(platform string, region string, azs []string
 	cluster string, service string, opts *manage.CatalogCassandraOptions, res *common.Resources) (*manage.CreateServiceRequest, error) {
 	// generate service ReplicaConfigs
 	if len(opts.JmxRemoteUser) == 0 {
-		opts.JmxRemoteUser = DefaultJmxRemoteUser
+		opts.JmxRemoteUser = catalog.JmxDefaultRemoteUser
 	}
 	if len(opts.JmxRemotePasswd) == 0 {
 		opts.JmxRemotePasswd = utils.GenUUID()
@@ -209,9 +205,9 @@ func GenReplicaConfigs(platform string, region string, cluster string, service s
 
 		// create the jmxremote.password file
 		jmxCfg := &manage.ReplicaConfigFile{
-			FileName: jmxRemotePasswdConfFileName,
-			FileMode: jmxRemotePasswdConfFileMode,
-			Content:  fmt.Sprintf("%s %s\n", opts.JmxRemoteUser, opts.JmxRemotePasswd),
+			FileName: catalog.JmxRemotePasswdConfFileName,
+			FileMode: catalog.JmxRemotePasswdConfFileMode,
+			Content:  fmt.Sprintf(catalog.JmxFileContent, opts.JmxRemoteUser, opts.JmxRemotePasswd),
 		}
 
 		configs := []*manage.ReplicaConfigFile{sysCfg, yamlCfg, rackdcCfg, jvmCfg, logCfg, jmxCfg}
@@ -295,12 +291,12 @@ func NewJVMConfContent(heapSizeMB int64) string {
 
 // IsJmxConfFile checks if the file is jmx conf file
 func IsJmxConfFile(filename string) bool {
-	return filename == jmxRemotePasswdConfFileName
+	return filename == catalog.JmxRemotePasswdConfFileName
 }
 
 // NewJmxConfContent returns the new jmxremote.password file content
 func NewJmxConfContent(jmxUser string, jmxPasswd string) string {
-	return fmt.Sprintf("%s %s\n", jmxUser, jmxPasswd)
+	return fmt.Sprintf(catalog.JmxFileContent, jmxUser, jmxPasswd)
 }
 
 const (

catalog/types.go

@@ -5,4 +5,12 @@ const (
 	SYS_FILE_NAME = "sys.conf"
 
 	BindAllIP = "0.0.0.0"
+
+	JmxRemotePasswdConfFileName = "jmxremote.password"
+	JmxRemotePasswdConfFileMode = 0400
+	// the default password is uuid for better security
+	// every service will define its own jmx port
+	JmxDefaultRemoteUser = "jmxuser"
+	// jmx file content format: "user passwd"
+	JmxFileContent = "%s %s\n"
 )

syssvc/firecamp-service-cli/main.go

@@ -14,6 +14,7 @@ import (
 
 	"golang.org/x/net/context"
 
+	"github.com/cloudstax/firecamp/catalog"
 	"github.com/cloudstax/firecamp/catalog/cassandra"
 	"github.com/cloudstax/firecamp/catalog/consul"
 	"github.com/cloudstax/firecamp/catalog/elasticsearch"
@@ -81,8 +82,8 @@ var (
 
 	// The Cassandra service specific parameters
 	casHeapSizeMB = flag.Int64("cas-heap-size", cascatalog.DefaultHeapMB, "The Cassandra JVM heap size, unit: MB")
-	casJmxUser    = flag.String("cas-jmx-user", cascatalog.DefaultJmxRemoteUser, "The Cassandra JMX remote user")
-	casJmxPasswd  = flag.String("cas-jmx-passwd", "", "The Cassandra JMX. If leave as empty, an uuid will be generated automatically")
+	casJmxUser    = flag.String("cas-jmx-user", catalog.JmxDefaultRemoteUser, "The Cassandra JMX remote user")
+	casJmxPasswd  = flag.String("cas-jmx-passwd", "", "The Cassandra JMX password. If leave as empty, an uuid will be generated automatically")
 
 	// The postgres service creation specific parameters.
 	pgReplUser       = flag.String("pg-repluser", "repluser", "The PostgreSQL replication user that the standby DB replicates from the primary")