Merge pull request meanjs#349 from lirantal/bugfix-348-article-not-found

fixing issue meanjs#348 - instead of returning a server error 500 on article loading which isnt found we'll throw a 404 with json message

Author: lirantal

app/controllers/articles.server.controller.js

@@ -88,9 +88,20 @@ exports.list = function(req, res) {
  * Article middleware
  */
 exports.articleByID = function(req, res, next, id) {
+
+	if (!mongoose.Types.ObjectId.isValid(id)) {
+		return res.status(400).send({
+			message: 'Article is invalid'
+		});
+	}
+
 	Article.findById(id).populate('user', 'displayName').exec(function(err, article) {
 		if (err) return next(err);
-		if (!article) return next(new Error('Failed to load article ' + id));
+		if (!article) {
+			return res.status(404).send({
+  				message: 'Article not found'
+  			});
+		}
 		req.article = article;
 		next();
 	});

app/tests/article.server.routes.test.js

@@ -201,6 +201,17 @@ describe('Article CRUD tests', function() {
 		});
 	});
 
+	it('should return proper error for single article which doesnt exist, if not signed in', function(done) {
+		request(app).get('/articles/test')
+			.end(function(req, res) {
+				// Set assertion
+				res.body.should.be.an.Object.with.property('message', 'Article is invalid');
+
+				// Call the assertion callback
+				done();
+			});
+	});
+
 	it('should be able to delete an article if signed in', function(done) {
 		agent.post('/auth/signin')
 			.send(credentials)