Fix regression: Allow searching in all values

Author: uglide

src/modules/value-editor/valueviewmodel.cpp

@@ -9,12 +9,17 @@ ValueEditor::ValueViewModel::ValueViewModel(QSharedPointer<Model> model)
     : BaseListModel(),
       m_model(model),
       m_startFramePosition(0),
-      m_lastLoadedRowFrameSize(0) {}
+      m_lastLoadedRowFrameSize(0),
+      m_singlePageMode(false) {}
 
 int ValueEditor::ValueViewModel::rowCount(const QModelIndex& parent) const {
   Q_UNUSED(parent);
 
-  return m_lastLoadedRowFrameSize;
+  if (m_singlePageMode) {
+    return m_model->rowsCount();
+  } else {
+    return m_lastLoadedRowFrameSize;
+  }
 }
 
 QVariant ValueEditor::ValueViewModel::data(const QModelIndex& index,
@@ -99,6 +104,16 @@ void ValueEditor::ValueViewModel::reload() {
   });
 }
 
+void ValueEditor::ValueViewModel::setSinglePageMode(bool v) {
+  m_singlePageMode = v;
+  emit singlePageModeChanged();
+}
+
+bool ValueEditor::ValueViewModel::singlePageMode() const
+{
+    return m_singlePageMode;
+}
+
 bool ValueEditor::ValueViewModel::isRowLoaded(int i) {
   return m_model->isRowLoaded(i);
 }

src/modules/value-editor/valueviewmodel.h

@@ -11,6 +11,7 @@ namespace ValueEditor {
 class ValueViewModel : public BaseListModel {
   Q_OBJECT
 
+  Q_PROPERTY(bool singlePageMode READ singlePageMode WRITE setSinglePageMode NOTIFY singlePageModeChanged)
   Q_PROPERTY(int totalRowCount READ totalRowCount NOTIFY totalRowCountChanged)
   Q_PROPERTY(int pageSize READ pageSize NOTIFY pageSizeChanged)
   Q_PROPERTY(
@@ -44,6 +45,9 @@ class ValueViewModel : public BaseListModel {
   Q_INVOKABLE void loadRows(int start, int limit);
   Q_INVOKABLE void reload();
 
+  void setSinglePageMode(bool v);
+  bool singlePageMode() const;
+
   int totalRowCount();
   int pageSize();
   QVariantList columnNames();
@@ -57,6 +61,7 @@ class ValueViewModel : public BaseListModel {
   void keyRenamed();
   void keyRemoved();
   void keyTTLChanged();
+  void singlePageModeChanged();
 
  protected:
   int mapRowIndex(int i);
@@ -65,6 +70,7 @@ class ValueViewModel : public BaseListModel {
   QSharedPointer<Model> m_model;
   int m_startFramePosition;
   int m_lastLoadedRowFrameSize;
+  bool m_singlePageMode;
 };
 
 }  // namespace ValueEditor

src/qml/value-editor/ValueTabs.qml

@@ -71,6 +71,13 @@ Repeater {
                 filterSyntax: SortFilterProxyModel.Wildcard
                 filterCaseSensitivity: Qt.CaseInsensitive
                 filterRole: keyTab.keyModel ? table.getColumn(1).role : ""
+
+                Component.onCompleted:  {
+                    if (keyTab.keyModel && keyTab.keyModel.singlePageMode) {
+                        // NOTE(u_glide): disable live search in all values
+                        filterString = table.searchField.text
+                    }
+                }
             }
         }
 
@@ -572,14 +579,48 @@ Repeater {
                                 }
                             }
 
-                            TextField {
-                                id: searchField
+                            RowLayout {
+                                Layout.preferredWidth: 195
+
+                                TextField {
+                                    id: searchField
+
+                                    Layout.fillWidth: true
+
+                                    readOnly: keyTab.keyModel.singlePageMode
+                                    placeholderText: qsTranslate("RDM","Search on page...")
+
+                                    Component.onCompleted: {
+                                        table.searchField = searchField
+                                    }
+                                }
+
+                                Button {
+                                    id: clearGlobalSearch
+                                    visible: keyTab.keyModel.singlePageMode
+
+                                    iconSource: "qrc:/images/clear.svg"
+
+                                    onClicked: {
+                                        wrapper.showLoader()
+                                        searchField.text = ""
+                                        keyTab.keyModel.singlePageMode = false
+                                        reLoadAction.trigger()
+                                    }
+                                }
+                            }
+
+                            Button {
+                                id: globalSearch
 
                                 Layout.preferredWidth: 195
-                                placeholderText: qsTranslate("RDM","Search on page...")
+                                iconSource: "qrc:/images/execute.svg"
+                                text: qsTranslate("RDM","Search through All values")
 
-                                Component.onCompleted: {
-                                    table.searchField = searchField
+                                onClicked: {
+                                    wrapper.showLoader()
+                                    keyTab.keyModel.singlePageMode = true
+                                    keyTab.keyModel.loadRows(0, keyTab.keyModel.totalRowCount)
                                 }
                             }
 

src/resources/images.qrc

@@ -14,6 +14,7 @@
         <file alias="alert.svg">images/alert.svg</file>
         <file alias="add.svg">images/add.svg</file>
         <file alias="import.svg">images/import.svg</file>
+        <file alias="execute.svg">images/execute.svg</file>
         <file alias="export.svg">images/export.svg</file>
         <file alias="editdb.svg">images/editdb.svg</file>
         <file alias="delete.svg">images/delete.svg</file>