Merge pull request #147 from codehs/z-text-dimension-fix

call resetDimensions on Text when we update the label

Author: zgalant

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "chs-js-lib",
-    "version": "0.3.4",
+    "version": "0.3.5",
     "description": "JavaScript graphics library used in CodeHS's platform.",
     "main": "dist/chs.cjs",
     "module": "dist/chs.mjs",

package.json

@@ -122,6 +122,7 @@ class Text extends Thing {
             );
         }
         this.label = label;
+        this.resetDimensions()
     }
 
     /**
@@ -143,6 +144,7 @@ class Text extends Thing {
             );
         }
         this.label = label;
+        this.resetDimensions()
     }
 
     /**

src/graphics/text.js

@@ -87,6 +87,12 @@ describe('Text', () => {
             t.setText('fdsa');
             expect(t.label).toEqual('fdsa');
         });
+        it('Updates dimensions', () => {
+            const t = new Text('mmmm');
+            const originalWidth = t.getWidth();
+            t.setText('mmmmmmm');
+            expect(t.getWidth()).toBeGreaterThan(originalWidth);
+        });
     });
     describe('setLabel', () => {
         it('Errors for invalid arguments', () => {
@@ -109,6 +115,12 @@ describe('Text', () => {
             t.setLabel('fdsa');
             expect(t.label).toEqual('fdsa');
         });
+        it('Updates dimensions', () => {
+            const t = new Text('mmmm');
+            const originalWidth = t.getWidth();
+            t.setLabel('mmmmmmm');
+            expect(t.getWidth()).toBeGreaterThan(originalWidth);
+        });
     });
     describe('containsPoint', () => {
         it('Checks if a point is contained in the Text', () => {