Merge pull request meteor#8544 from abernix/abernix/fix-windows-dev-bundle-extract-error

Detect dev_bundle download errors and fail appropriately on Windows.

Author: abernix

meteor.bat

@@ -16,6 +16,10 @@ IF EXIST "%~dp0\.git" (
     REM need `< con` so that we can run this file from Node
     REM (See http://stackoverflow.com/questions/9155289/calling-powershell-from-nodejs)
     PowerShell.exe -executionpolicy ByPass -file "%~dp0\scripts\windows\download-dev-bundle.ps1" < con
+    IF errorlevel 1 (
+      echo An error occurred while obtaining the dev_bundle.  Please try again.
+      exit /b 1
+    )
   )
 
   rem if dev_bundle is the wrong version, remove it and get a new one
@@ -28,6 +32,10 @@ IF EXIST "%~dp0\.git" (
       exit /b 1
     )
     PowerShell.exe -executionpolicy ByPass -file "%~dp0\scripts\windows\download-dev-bundle.ps1" < con
+    IF errorlevel 1 (
+      echo An error occurred while obtaining the dev_bundle.  Please try again.
+      exit /b 1
+    )
   )
 
   rem Only set this when we're in a checkout. When running from a release,

scripts/windows/download-dev-bundle.ps1

@@ -42,6 +42,9 @@ if (Test-Path $devbundle_zip) {
 Write-Host "Extracting $TARBALL to the dev_bundle directory"
 
 cmd /C "7z.exe x $devbundle_zip -so | 7z.exe x -aoa -si -ttar -o$CHECKOUT_DIR\dev_bundle_XXX" | out-null
+if ($LASTEXITCODE -ne 0) {
+  Exit 1
+}
 
 $downloaded_tmp = $CHECKOUT_DIR + "\dev_bundle_XXX"
 $downloaded_path = $downloaded_tmp + "\dev_bundle_" + $PLATFORM + "_" + $BUNDLE_VERSION