-
Notifications
You must be signed in to change notification settings - Fork 23
Added oAuth by Github #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HI @TORPEDO99 I worked on your pull request please update the pull request as follows:-
|
headers: { "Access-Control-Allow-Origin": "*" } |
Integrated a simple method to extract the access_token from the response and store it locally to be used for further authorized github api calls. |
Switched to using environment variables instead of saving client secret and id in a file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍 Please squash all the commits to one with all the commit messages under it @TORPEDO99
Added requested changes Changed oauth credentials Added a third party proxy to bypass cors errors Added access token extractor switched to environment variables Delete .env.local Added setup steps in readme
ABOUT
Made a few changes to Login.vue so that the access token is retrieved from github.
Resolves #15
TESTING
http://localhost:8080/#/auth
.env
file in the root folder of the project (where package.json is)VUE_APP_CLIENT_ID=<client id>
VUE_APP_CLIENT_SECRET=<client secret>
npm start serve