Skip to content

Scss error when compiling default theme #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tilsammans opened this issue Jun 17, 2016 · 2 comments · Fixed by #28
Closed

Scss error when compiling default theme #27

tilsammans opened this issue Jun 17, 2016 · 2 comments · Fixed by #28

Comments

@tilsammans
Copy link
Contributor

Leaving this here, still investigating a fix.

When I try to include this gem's default theme the css won't compile:

Sass::SyntaxError
Invalid CSS after "...    line-height": expected ")", was ": 1.3em"

pointing to

stylesheets/pageflow/external_links/themes/default.scss at line 70

line-height: 1.3em
@tf
Copy link
Member

tf commented Jun 17, 2016

Yes, forgot about this. You are completely right. The default.scss file already depends on Sass 3.4 and some helpers from the coming configurable Pageflow default theme. There is a separate themes/legacy.scss file which you can use. I'll update the readme.

@tf tf mentioned this issue Jun 17, 2016
Merged
@tf tf closed this as completed in #28 Jun 17, 2016
@tilsammans
Copy link
Contributor Author

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention legacy theme in readme codevise/pageflow-external-links
2 participants
@tilsammans @tf