Skip to content

Field of view adjust doesn't work #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tilsammans opened this issue Aug 2, 2016 · 2 comments · Fixed by #30
Closed

Field of view adjust doesn't work #29

tilsammans opened this issue Aug 2, 2016 · 2 comments · Fixed by #30
Labels

Comments

@tilsammans
Copy link
Contributor

When I click the 'Adjust Field of View' button for an external site thumbnail, nothing happens and this is shown in the console:

TypeError: this.model.getFilePosition is not a function. (In 'this.model.getFilePosition(this.options.propertyName,"y")', 'this.model.getFilePosition' is undefined)

(issue transferred from codevise/pageflow-linkmap-page#6)

@tf
Copy link
Member

tf commented Aug 2, 2016

The imagePositioning: false option has to be changed to positioning: false to prevent the button from being displayed.

The option has been renamed a long time ago and obviously nobody has noticed the remaining usage of the old name here. Can you take a look and test whether this solves the issue?

EDIT: One could of course also consider actually implementing field of view here. But I'm not sure it's worth it.

@tf tf added the bug label Aug 2, 2016
@tilsammans
Copy link
Contributor Author

Seems to work, the button is gone. I will submit a pull request.

I found two references to imagePositioning by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants