Merge pull request #5 from Jille/master

colder · colder · commit b725d14721fa · 2012-04-13T09:15:06.000-07:00
Fix comment and test
diff --git a/tests/weakref_008.phpt b/tests/weakref_008.phpt
@@ -11,6 +11,6 @@ unset($ref);
 echo "done...\n";
 ?>
 --EXPECTF--
-set...
+get...
 unset...
 done...
diff --git a/wr_weakref.c b/wr_weakref.c
@@ -56,7 +56,7 @@ static int wr_weakref_ref_release(wr_weakref_object *intern TSRMLS_DC) /* {{{ */
 	if (intern->valid && (intern->acquired > 0)) {
 		intern->acquired--;
 		if (intern->acquired == 0) {
-			// We need to register that ref so that the object doesn't get collected
+			// We need to unregister that ref so that the object can get collected
 			Z_OBJ_HANDLER_P(intern->ref, del_ref)(intern->ref TSRMLS_CC);
 		}
 		return SUCCESS;

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ static int wr_weakref_ref_release(wr_weakref_object intern TSRMLS_DC) / {{{ */`
`56`	`56`	`if (intern->valid && (intern->acquired > 0)) {`
`57`	`57`	`intern->acquired--;`
`58`	`58`	`if (intern->acquired == 0) {`
`59`		`- // We need to register that ref so that the object doesn't get collected`
	`59`	`+ // We need to unregister that ref so that the object can get collected`
`60`	`60`	`Z_OBJ_HANDLER_P(intern->ref, del_ref)(intern->ref TSRMLS_CC);`
`61`	`61`	`}`
`62`	`62`	`return SUCCESS;`