From 081353defa715f08b2c6db9d83813004d4639b46 Mon Sep 17 00:00:00 2001 From: Jille Timmermans Date: Fri, 13 Apr 2012 17:50:56 +0200 Subject: [PATCH 1/2] Fix comment added in 281ad6d42ef3c5ce7877db4a67c21d7420b55308 --- wr_weakref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wr_weakref.c b/wr_weakref.c index 01079a6..68d8349 100644 --- a/wr_weakref.c +++ b/wr_weakref.c @@ -56,7 +56,7 @@ static int wr_weakref_ref_release(wr_weakref_object *intern TSRMLS_DC) /* {{{ */ if (intern->valid && (intern->acquired > 0)) { intern->acquired--; if (intern->acquired == 0) { - // We need to register that ref so that the object doesn't get collected + // We need to unregister that ref so that the object can get collected Z_OBJ_HANDLER_P(intern->ref, del_ref)(intern->ref TSRMLS_CC); } return SUCCESS; From ef8380939b50bbacc421e084d53764294563c21f Mon Sep 17 00:00:00 2001 From: Jille Timmermans Date: Fri, 13 Apr 2012 17:57:44 +0200 Subject: [PATCH 2/2] Fix typo in tests expect --- tests/weakref_008.phpt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/weakref_008.phpt b/tests/weakref_008.phpt index 8ca9939..f59d5a9 100644 --- a/tests/weakref_008.phpt +++ b/tests/weakref_008.phpt @@ -11,6 +11,6 @@ unset($ref); echo "done...\n"; ?> --EXPECTF-- -set... +get... unset... done...