Skip to content

Commit 6b1be52

Browse files
bluetideprosapegin
authored andcommitted
Fix: Update bottom spacing for "Props" toggle + tweak contributing guidelines (styleguidist#523)
1 parent 7effc4f commit 6b1be52

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

Contributing.md renamed to .github/Contributing.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ Or run tests in watch mode:
3636
npm run test:watch
3737
```
3838

39+
To update the Jest snapshots:
40+
41+
```bash
42+
npm run test:jest -- -u
43+
```
44+
3945
**Don’t forget to add tests and update documentation for your changes.**
4046

4147
**Please update npm lock file (`package-lock.json`) if you add new dependencies.**
File renamed without changes.

Readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ The change log can be found on the [Releases page](https://github.com/styleguidi
6464

6565
## Contributing
6666

67-
Everyone is welcome to contribute. Please take a moment to review the [contributing guidelines](Contributing.md).
67+
Everyone is welcome to contribute. Please take a moment to review the [contributing guidelines](.github/Contributing.md).
6868

6969
## Authors and license
7070

docs/Development.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Developer guide
22

3-
*For basics see [How to contribute](https://github.com/styleguidist/react-styleguidist/blob/master/Contributing.md).*
3+
*For basics see [How to contribute](https://github.com/styleguidist/react-styleguidist/blob/master/.github/Contributing.md).*
44

5-
Styleguidist isn’t an ordinary single page app and some design decisions may look confusing to an outsider. In this guide we'll explain these decisions to un-confuse potential contributors.
5+
Styleguidist isn’t an ordinary single page app and some design decisions may look confusing to an outsider. In this guide we'll explain these decisions to un-confuse potential contributors.
66

77
The main thing is that we’re running two apps at the same time: user’s components and Styleguidist UI. They share a webpack configuration and have styles in the same scope (there’s only one scope in CSS). And we can control only one of these two apps: Styleguidist UI. That puts us under some restrictions:
88

src/rsg-components/ReactComponent/ReactComponentRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const styles = ({ color, fontSize, space }) => ({
1414
marginBottom: space[3],
1515
},
1616
tabButtons: {
17-
marginBottom: space[1],
17+
marginBottom: space[2],
1818
},
1919
docs: {
2020
color: color.base,

0 commit comments

Comments
 (0)