Skip to content

Numeric labels misparsed as IP address #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bu11etmagnet opened this issue Sep 22, 2014 · 4 comments · Fixed by cpp-netlib/uri#53
Closed

Numeric labels misparsed as IP address #450

Bu11etmagnet opened this issue Sep 22, 2014 · 4 comments · Fixed by cpp-netlib/uri#53
Labels
URI

Comments

@Bu11etmagnet
Copy link

"1.2.3.4.5.a.com" is incorrectly rejected (is_valid is false). This is because the "1.2.3.4" part is treated as an IP address, and then "first==last" is false in uri.ipp:178

This is with 0.11.1.RC2
@glynos
Copy link
Member

glynos commented Sep 22, 2014

Can you test if this is still an issue in the new uri: https://github.com/cpp-netlib/uri/

@Bu11etmagnet
Copy link
Author

Same thing, except it throws an uri_syntax_error

@lacop lacop mentioned this issue Dec 1, 2014
Merged
@Bu11etmagnet Bu11etmagnet mentioned this issue Dec 5, 2014
Closed
@glynos
Copy link
Member

glynos commented Dec 8, 2014

This was fixed in URI v1.0, but not in 0.11

@glynos glynos reopened this Dec 8, 2014
@glynos glynos added the URI label Jun 14, 2016
@glynos
Copy link
Member

glynos commented Jun 14, 2016

This won't be fixed in 0.13, so I will close it now.

@glynos glynos closed this as completed Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
URI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix host parsing priority according to RFC 3986. lacop/uri
2 participants
@glynos @Bu11etmagnet