Drop getExternal method from JavaSignatureFormatter

Author: zarechenskiy

compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/resolver/PsiBasedMethodSignatureChecker.java

@@ -91,7 +91,7 @@ private void checkFunctionOverridesCorrectly(
                       + "super class = " + superFunction.getContainingDeclaration() + "\n"
                       + "sub function = " + function + "\n"
                       + "sub class = " + function.getContainingDeclaration() + "\n"
-                      + "sub method = " + JavaSignatureFormatter.getInstance().getExternalName(method) + "\n"
+                      + "sub method = " + method + "\n"
                       + "@KotlinSignature = " + SignaturesUtil.getKotlinSignature(externalAnnotationResolver, method));
         }
     }

compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaSignatureFormatterImpl.java

@@ -31,11 +31,4 @@ public String formatMethod(@NotNull JavaMethod method) {
         return PsiFormatUtil.formatMethod(((JavaMethodImpl) method).getPsi(), PsiSubstitutor.EMPTY, SHOW_NAME | SHOW_PARAMETERS,
                                           SHOW_TYPE | SHOW_FQ_CLASS_NAMES);
     }
-
-    @NotNull
-    @Override
-    public String getExternalName(@NotNull JavaMethod method) {
-        String result = PsiFormatUtil.getExternalName(((JavaMethodImpl) method).getPsi());
-        return result == null ? "null" : result;
-    }
 }

core/descriptor.loader.java/src/org/jetbrains/jet/lang/resolve/java/structure/JavaSignatureFormatter.java

@@ -41,12 +41,4 @@ public static JavaSignatureFormatter getInstance() {
      */
     @NotNull
     public abstract String formatMethod(@NotNull JavaMethod method);
-
-    /**
-     * @return a formatted signature of a method, showing method's containing class, return type and parameter types, all names are fully
-     * qualified, e.g.:
-     * {@code "java.lang.Class boolean isAnnotationPresent(java.lang.Class<? extends java.lang.annotation.Annotation>)"}
-     */
-    @NotNull
-    public abstract String getExternalName(@NotNull JavaMethod method);
 }