Skip to content

Commit 956e51d

Browse files
tom-vanP33M
authored andcommitted
jtag/drivers/cmsis_dap: use dap parameter instead of cmsis_dap_handle
Replace the direct dereference of cmsis_dap_handle by dereference of the dap function parameter wherever possible. Signed-off-by: Tomas Vanek <[email protected]> Change-Id: I32601dbe0270267642720a8524706aa76d187c3b Reviewed-on: https://review.openocd.org/c/openocd/+/7361 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]>
1 parent c592222 commit 956e51d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/jtag/drivers/cmsis_dap.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,14 +290,15 @@ static void cmsis_dap_close(struct cmsis_dap *dap)
290290
dap->backend = NULL;
291291
}
292292

293-
free(cmsis_dap_handle->packet_buffer);
294-
free(cmsis_dap_handle);
295-
cmsis_dap_handle = NULL;
293+
free(dap->packet_buffer);
296294

297295
for (int i = 0; i < MAX_PENDING_REQUESTS; i++) {
298296
free(dap->pending_fifo[i].transfers);
299297
dap->pending_fifo[i].transfers = NULL;
300298
}
299+
300+
free(cmsis_dap_handle);
301+
cmsis_dap_handle = NULL;
301302
}
302303

303304
static void cmsis_dap_flush_read(struct cmsis_dap *dap)
@@ -328,7 +329,7 @@ static int cmsis_dap_xfer(struct cmsis_dap *dap, int txlen)
328329
dap->pending_fifo_get_idx = 0;
329330
}
330331

331-
uint8_t current_cmd = cmsis_dap_handle->command[0];
332+
uint8_t current_cmd = dap->command[0];
332333
int retval = dap->backend->write(dap, txlen, LIBUSB_TIMEOUT_MS);
333334
if (retval < 0)
334335
return retval;
@@ -338,7 +339,7 @@ static int cmsis_dap_xfer(struct cmsis_dap *dap, int txlen)
338339
if (retval < 0)
339340
return retval;
340341

341-
uint8_t *resp = cmsis_dap_handle->response;
342+
uint8_t *resp = dap->response;
342343
if (resp[0] == DAP_ERROR) {
343344
LOG_ERROR("CMSIS-DAP command 0x%" PRIx8 " not implemented", current_cmd);
344345
return ERROR_NOT_IMPLEMENTED;
@@ -743,7 +744,7 @@ static int cmsis_dap_cmd_dap_swo_data(
743744

744745
static void cmsis_dap_swd_write_from_queue(struct cmsis_dap *dap)
745746
{
746-
uint8_t *command = cmsis_dap_handle->command;
747+
uint8_t *command = dap->command;
747748
struct pending_request_block *block = &dap->pending_fifo[dap->pending_fifo_put_idx];
748749

749750
LOG_DEBUG_IO("Executing %d queued transactions from FIFO index %u",

0 commit comments

Comments
 (0)