Skip to content

Commit be9dd22

Browse files
shikharshikhar
committed
CC-265: update data types expected in dialect tests
1 parent bdf8d4e commit be9dd22

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

‎src/test/java/io/confluent/connect/jdbc/sink/dialect/OracleDialectTest.java

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ public void handleCreateTableMultiplePKColumns() {
3939
));
4040

4141
String expected = "CREATE TABLE \"tableA\" (" + System.lineSeparator() +
42-
"\"userid\" INTEGER NOT NULL," + System.lineSeparator() +
43-
"\"userdataid\" INTEGER NOT NULL," + System.lineSeparator() +
44-
"\"info\" VARCHAR(256) NULL," + System.lineSeparator() +
42+
"\"userid\" NUMBER NOT NULL," + System.lineSeparator() +
43+
"\"userdataid\" NUMBER NOT NULL," + System.lineSeparator() +
44+
"\"info\" NVARCHAR2(4000) NULL," + System.lineSeparator() +
4545
"PRIMARY KEY(\"userid\",\"userdataid\"))";
4646
assertEquals(expected, actual);
4747
}
@@ -60,14 +60,14 @@ public void handleCreateTableOnePKColumn() {
6060
));
6161

6262
String expected = "CREATE TABLE \"tableA\" (" + System.lineSeparator() +
63-
"\"col1\" INTEGER NOT NULL," + System.lineSeparator() +
64-
"\"col2\" NUMBER(19) NULL," + System.lineSeparator() +
65-
"\"col3\" VARCHAR(256) NULL," + System.lineSeparator() +
66-
"\"col4\" REAL NULL," + System.lineSeparator() +
63+
"\"col1\" NUMBER NOT NULL," + System.lineSeparator() +
64+
"\"col2\" NUMBER NULL," + System.lineSeparator() +
65+
"\"col3\" NVARCHAR2(4000) NULL," + System.lineSeparator() +
66+
"\"col4\" BINARY_FLOAT NULL," + System.lineSeparator() +
6767
"\"col5\" BINARY_DOUBLE NULL," + System.lineSeparator() +
68-
"\"col6\" NUMBER(1,0) NULL," + System.lineSeparator() +
69-
"\"col7\" TINYINT NULL," + System.lineSeparator() +
70-
"\"col8\" SMALLINT NULL," + System.lineSeparator() +
68+
"\"col6\" NUMBER NULL," + System.lineSeparator() +
69+
"\"col7\" NUMBER NULL," + System.lineSeparator() +
70+
"\"col8\" NUMBER NULL," + System.lineSeparator() +
7171
"PRIMARY KEY(\"col1\"))";
7272
assertEquals(expected, actual);
7373
}
@@ -86,14 +86,14 @@ public void handleCreateTableNoPKColumn() {
8686
));
8787

8888
String expected = "CREATE TABLE \"tableA\" (" + System.lineSeparator() +
89-
"\"col1\" INTEGER NULL," + System.lineSeparator() +
90-
"\"col2\" NUMBER(19) NULL," + System.lineSeparator() +
91-
"\"col3\" VARCHAR(256) NULL," + System.lineSeparator() +
92-
"\"col4\" REAL NULL," + System.lineSeparator() +
89+
"\"col1\" NUMBER NULL," + System.lineSeparator() +
90+
"\"col2\" NUMBER NULL," + System.lineSeparator() +
91+
"\"col3\" NVARCHAR2(4000) NULL," + System.lineSeparator() +
92+
"\"col4\" BINARY_FLOAT NULL," + System.lineSeparator() +
9393
"\"col5\" BINARY_DOUBLE NULL," + System.lineSeparator() +
94-
"\"col6\" NUMBER(1,0) NULL," + System.lineSeparator() +
95-
"\"col7\" TINYINT NULL," + System.lineSeparator() +
96-
"\"col8\" SMALLINT NULL)";
94+
"\"col6\" NUMBER NULL," + System.lineSeparator() +
95+
"\"col7\" NUMBER NULL," + System.lineSeparator() +
96+
"\"col8\" NUMBER NULL)";
9797
assertEquals(expected, actual);
9898
}
9999

@@ -113,14 +113,14 @@ public void handleAmendAddColumns() {
113113
assertEquals(1, actual.size());
114114

115115
String expected = "ALTER TABLE \"tableA\" ADD(" + System.lineSeparator() +
116-
"\"col1\" INTEGER NULL," + System.lineSeparator() +
117-
"\"col2\" NUMBER(19) NULL," + System.lineSeparator() +
118-
"\"col3\" VARCHAR(256) NULL," + System.lineSeparator() +
119-
"\"col4\" REAL NULL," + System.lineSeparator() +
116+
"\"col1\" NUMBER NULL," + System.lineSeparator() +
117+
"\"col2\" NUMBER NULL," + System.lineSeparator() +
118+
"\"col3\" NVARCHAR2(4000) NULL," + System.lineSeparator() +
119+
"\"col4\" BINARY_FLOAT NULL," + System.lineSeparator() +
120120
"\"col5\" BINARY_DOUBLE NULL," + System.lineSeparator() +
121-
"\"col6\" NUMBER(1,0) NULL," + System.lineSeparator() +
122-
"\"col7\" TINYINT NULL," + System.lineSeparator() +
123-
"\"col8\" SMALLINT NULL)";
121+
"\"col6\" NUMBER NULL," + System.lineSeparator() +
122+
"\"col7\" NUMBER NULL," + System.lineSeparator() +
123+
"\"col8\" NUMBER NULL)";
124124
assertEquals(expected, actual.get(0));
125125
}
126126

‎src/test/java/io/confluent/connect/jdbc/sink/dialect/PostgreSqlDialectTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void handleCreateTableOnePKColumn() {
7272
"\"col1\" INT NOT NULL," + System.lineSeparator() +
7373
"\"col2\" BIGINT NULL," + System.lineSeparator() +
7474
"\"col3\" TEXT NULL," + System.lineSeparator() +
75-
"\"col4\" FLOAT NULL," + System.lineSeparator() +
75+
"\"col4\" REAL NULL," + System.lineSeparator() +
7676
"\"col5\" DOUBLE PRECISION NULL," + System.lineSeparator() +
7777
"\"col6\" BOOLEAN NULL," + System.lineSeparator() +
7878
"\"col7\" SMALLINT NULL," + System.lineSeparator() +
@@ -98,7 +98,7 @@ public void handleCreateTableNoPKColumn() {
9898
"\"col1\" INT NULL," + System.lineSeparator() +
9999
"\"col2\" BIGINT NULL," + System.lineSeparator() +
100100
"\"col3\" TEXT NULL," + System.lineSeparator() +
101-
"\"col4\" FLOAT NULL," + System.lineSeparator() +
101+
"\"col4\" REAL NULL," + System.lineSeparator() +
102102
"\"col5\" DOUBLE PRECISION NULL," + System.lineSeparator() +
103103
"\"col6\" BOOLEAN NULL," + System.lineSeparator() +
104104
"\"col7\" SMALLINT NULL," + System.lineSeparator() +
@@ -125,7 +125,7 @@ public void handleAmendAddColumns() {
125125
"ADD \"col1\" INT NULL," + System.lineSeparator() +
126126
"ADD \"col2\" BIGINT NULL," + System.lineSeparator() +
127127
"ADD \"col3\" TEXT NULL," + System.lineSeparator() +
128-
"ADD \"col4\" FLOAT NULL," + System.lineSeparator() +
128+
"ADD \"col4\" REAL NULL," + System.lineSeparator() +
129129
"ADD \"col5\" DOUBLE PRECISION NULL," + System.lineSeparator() +
130130
"ADD \"col6\" BOOLEAN NULL," + System.lineSeparator() +
131131
"ADD \"col7\" SMALLINT NULL," + System.lineSeparator() +

‎src/test/java/io/confluent/connect/jdbc/sink/dialect/SqlServerDialectTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void handleCreateTableMultiplePKColumns() {
6363
String expected = "CREATE TABLE [tableA] (" + System.lineSeparator() +
6464
"[userid] int NOT NULL," + System.lineSeparator() +
6565
"[userdataid] int NOT NULL," + System.lineSeparator() +
66-
"[info] varchar(256) NULL," + System.lineSeparator() +
66+
"[info] varchar(max) NULL," + System.lineSeparator() +
6767
"PRIMARY KEY([userid],[userdataid]))";
6868
assertEquals(expected, actual);
6969
}
@@ -84,7 +84,7 @@ public void handleCreateTableOnePKColumn() {
8484
String expected = "CREATE TABLE [tableA] (" + System.lineSeparator() +
8585
"[col1] int NOT NULL," + System.lineSeparator() +
8686
"[col2] bigint NULL," + System.lineSeparator() +
87-
"[col3] varchar(256) NULL," + System.lineSeparator() +
87+
"[col3] varchar(max) NULL," + System.lineSeparator() +
8888
"[col4] real NULL," + System.lineSeparator() +
8989
"[col5] float NULL," + System.lineSeparator() +
9090
"[col6] bit NULL," + System.lineSeparator() +
@@ -110,7 +110,7 @@ public void handleCreateTableNoPKColumn() {
110110
String expected = "CREATE TABLE [tableA] (" + System.lineSeparator() +
111111
"[col1] int NULL," + System.lineSeparator() +
112112
"[col2] bigint NULL," + System.lineSeparator() +
113-
"[col3] varchar(256) NULL," + System.lineSeparator() +
113+
"[col3] varchar(max) NULL," + System.lineSeparator() +
114114
"[col4] real NULL," + System.lineSeparator() +
115115
"[col5] float NULL," + System.lineSeparator() +
116116
"[col6] bit NULL," + System.lineSeparator() +
@@ -137,7 +137,7 @@ public void handleAmendAddColumns() {
137137
String expected = "ALTER TABLE [tableA] ADD" + System.lineSeparator() +
138138
"[col1] int NULL," + System.lineSeparator() +
139139
"[col2] bigint NULL," + System.lineSeparator() +
140-
"[col3] varchar(256) NULL," + System.lineSeparator() +
140+
"[col3] varchar(max) NULL," + System.lineSeparator() +
141141
"[col4] real NULL," + System.lineSeparator() +
142142
"[col5] float NULL," + System.lineSeparator() +
143143
"[col6] bit NULL," + System.lineSeparator() +

0 commit comments

Comments
 (0)