Missing $SSH_AUTH_SOCK would indicate a serious problem.

jglick · jglick · commit 7772af19738e · 2017-02-09T15:20:35.000-05:00
diff --git a/src/main/java/com/cloudbees/jenkins/plugins/sshagent/exec/ExecRemoteAgent.java b/src/main/java/com/cloudbees/jenkins/plugins/sshagent/exec/ExecRemoteAgent.java
@@ -72,10 +72,11 @@ public class ExecRemoteAgent implements RemoteAgent {
         }
         agentEnv = parseAgentEnv(new String(baos.toByteArray(), StandardCharsets.US_ASCII)); // TODO could include local filenames, better to look up remote charset
         
-        if (agentEnv.containsKey(AuthSocketVar))
+        if (agentEnv.containsKey(AuthSocketVar)) {
             socket = agentEnv.get(AuthSocketVar);
-        else
-            socket = ""; // socket is not set
+        } else {
+            throw new AbortException(AuthSocketVar + " was not included");
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,11 @@ public class ExecRemoteAgent implements RemoteAgent {`
`72`	`72`	`}`
`73`	`73`	`agentEnv = parseAgentEnv(new String(baos.toByteArray(), StandardCharsets.US_ASCII)); // TODO could include local filenames, better to look up remote charset`
`74`	`74`
`75`		`- if (agentEnv.containsKey(AuthSocketVar))`
	`75`	`+ if (agentEnv.containsKey(AuthSocketVar)) {`
`76`	`76`	`socket = agentEnv.get(AuthSocketVar);`
`77`		`- else`
`78`		`- socket = ""; // socket is not set`
	`77`	`+ } else {`
	`78`	`+ throw new AbortException(AuthSocketVar + " was not included");`
	`79`	`+ }`
`79`	`80`	`}`
`80`	`81`
`81`	`82`	`/**`