Skip to content

Commit 932bfaf

Browse files
Mi-Lajanvrany
authored andcommitted
Fixes executable flag in a temporary script for SSH_ASKPASS.
1 parent c206deb commit 932bfaf

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/main/java/com/cloudbees/jenkins/plugins/sshagent/exec/ExecRemoteAgent.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,6 @@ public String getSocket() {
101101
return socket;
102102
}
103103

104-
private boolean setReadOnlyForOwner(File file) {
105-
boolean ok = file.setExecutable(false, false);
106-
ok &= file.setWritable(false, false);
107-
ok &= file.setReadable(false, false);
108-
ok &= file.setReadable(true, true);
109-
return ok;
110-
}
111-
112104
/**
113105
* {@inheritDoc}
114106
*/
@@ -206,6 +198,14 @@ private String getAgentValue(String agentOutput, String envVar) {
206198
return agentOutput.substring(pos, end);
207199
}
208200

201+
private boolean setReadOnlyForOwner(File file) {
202+
boolean ok = file.setExecutable(false, false);
203+
ok &= file.setWritable(false, false);
204+
ok &= file.setReadable(false, false);
205+
ok &= file.setReadable(true, true);
206+
return ok;
207+
}
208+
209209
private File createAskpassScript() throws IOException {
210210
final String suffix;
211211
final String script;
@@ -221,7 +221,9 @@ private File createAskpassScript() throws IOException {
221221
askpassWriter.write(script);
222222
askpassWriter.close();
223223

224-
askpass.setExecutable(true, false);
224+
// executable only for a current user
225+
askpass.setExecutable(false, false);
226+
askpass.setExecutable(true, true);
225227
return askpass;
226228
}
227229
}

0 commit comments

Comments
 (0)