Skip to content

[jnigen] Change all com.github.dart_lang. package prefix to dev.dart. #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HosseinYousefi opened this issue Apr 29, 2025 · 2 comments
Open

Comments

@HosseinYousefi
Copy link
Member

It's somewhat weird that the packages have com.github eventhough they are not affiliated with the github organization.

@dcharkes
Copy link
Collaborator

I think we chose this because that's where the package is hosted. E.g. repository url, but that might not be the right thing to do. (Speaking as someone who almost never devs Java code.)

@HosseinYousefi
Copy link
Member Author

HosseinYousefi commented Apr 29, 2025

From https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

Companies use their reversed Internet domain name to begin their package names—for example, com.example.mypackage for a package named mypackage created by a programmer at example.com.

So I think it's a better idea to have our packages be dev.dart.jnigen.mypackage instead


Prior art in Flutter, we use io.flutter.xyz for package names there: https://api.flutter.dev/javadoc/io/flutter/embedding/engine/FlutterEngine.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants