Skip to content

[Null-aware elements] CFE Implementation #55955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 3 tasks
Tracked by #55949
chloestefantsova opened this issue Jun 7, 2024 · 0 comments
Closed
2 of 3 tasks
Tracked by #55949

[Null-aware elements] CFE Implementation #55955

chloestefantsova opened this issue Jun 7, 2024 · 0 comments
Assignees
@chloestefantsova
Labels
feature-null-aware-elements Implementation of the Null-aware elements feature legacy-area-front-end Legacy: Use area-dart-model instead. model-features General feature work in the analyzer and CFE.

Comments

@chloestefantsova
Copy link
Contributor

chloestefantsova commented Jun 7, 2024 •
edited
Loading

This issue is for implementing the feature in the CFE. It includes the following sub-tasks:

  • Enabling the feature for the case of null-aware elements in non-ambiguous collections (where sets are disambiguated from maps trivially) and not requiring type inference.
  • Enable type inference in non-ambiguous collections with null-aware elements.
  • Enable disambiguation between maps and sets in collections with null-aware elements.
@chloestefantsova chloestefantsova added legacy-area-front-end Legacy: Use area-dart-model instead. feature-null-aware-elements Implementation of the Null-aware elements feature labels Jun 7, 2024
@chloestefantsova chloestefantsova self-assigned this Jun 7, 2024
@chloestefantsova chloestefantsova mentioned this issue Jun 7, 2024
Closed
7 tasks
@johnniwinther johnniwinther added the model-features General feature work in the analyzer and CFE. label Jun 7, 2024
copybara-service bot pushed a commit that referenced this issue Jul 25, 2024
@chloestefantsova
[cfe] Add NullAwareElement internal AST node
f447745 
Part of #55955

Change-Id: I87752d98ecdd4e9198ee3cb955cf2fc46901fd2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377640
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 29, 2024
@chloestefantsova
[cfe] Implement type inference for NullAwareElement
2f3bca7 
Part of #55955

Change-Id: Idbede4120a95ead2502779d271e8f6dc96059ab6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377648
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 30, 2024
@chloestefantsova
[cfe] Add NullAwareMapEntry internal AST node
0b2b738 
Part of #55955

Change-Id: I47d2291b9647a000ae9a164029ffa82e2763858e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377822
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 31, 2024
@chloestefantsova
[cfe] Implement type inference for NullAwareMapEntry
3c29106 
Part of #55955

Change-Id: I31eb5ee38b4ed34d252713352637cc9760a57dd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377960
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 3, 2024
@chloestefantsova
[cfe] Force-enable flag null-aware-elements in unit tests
d9ef8f9 
Part of #55955

Change-Id: I41ca7e78c3b2012a132f2b87d1b65304ee04b4fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383321
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 2, 2024
@chloestefantsova
[cfe] Add an inference test for null-aware elements
5eb2996 
This CL also removes an obsoleted comment about adding flow analysis
to null-aware elements in lists and sets. Since the null-aware
elements don't introduce changes to the control flow in lists and
sets, such analysis isn't necessary.

Part of #55955

Change-Id: I3dbe3f0bd76ce19ff232dc5be20376f5c43f1323
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387962
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 17, 2024
@chloestefantsova
[cfe] Use the null-aware flag in upwards inference in map literals
c92712d 
Part of #55955

Change-Id: I73171619ee33b13087cc99aee8489c9fb27a445b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390700
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 28, 2024
@chloestefantsova
[cfe] Repair the evaluation order in null-aware map entries
d1d029f 
Closes #56848
Part of #55955

Change-Id: If1cda4a77cf42c0f75a6054c941b458cad13ebed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391960
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
feature-null-aware-elements Implementation of the Null-aware elements feature legacy-area-front-end Legacy: Use area-dart-model instead. model-features General feature work in the analyzer and CFE.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @johnniwinther