Skip to content

[Dot Shorthands] VS Code Support #60444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #57036
kallentu opened this issue Mar 31, 2025 · 3 comments
Closed
Tracked by #57036

[Dot Shorthands] VS Code Support #60444

kallentu opened this issue Mar 31, 2025 · 3 comments
Assignees
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. feature-dot-shorthands Implementation of the dot shorthands feature. P3 A lower priority bug or feature request

Comments

@kallentu
Copy link
Member

This issue tracks the work needed for VS Code support.

Dart Code issue filed: Dart-Code/Dart-Code#5470

cc. @jwren

@kallentu kallentu added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. feature-dot-shorthands Implementation of the dot shorthands feature. labels Mar 31, 2025
@bwilkerson bwilkerson added the P3 A lower priority bug or feature request label Apr 2, 2025
@jwren jwren removed their assignment Apr 14, 2025
@DanTup
Copy link
Collaborator

DanTup commented Apr 15, 2025

I suspect there won't be anything to do specifically for Dart-Code (since all language parsing is in the analyzer/server), although I'll keep this open to verify we don't need any changes to the textmate grammar since that does somewhat parse Dart (albeit in a very simplified way).

@DanTup DanTup self-assigned this Apr 15, 2025
@kallentu
Copy link
Member Author

That sounds good, thank you.

@DanTup
Copy link
Collaborator

DanTup commented Apr 17, 2025

I've confirmed that using the new syntax, there is no difference in colouring with the textmate grammar (which mostly leaves identifiers like these white, but invocations yellow):

Image

Semantic Tokens might be different (which is what most users will see overlaid over the textmate grammar), but the implementation of them is in the server (and included in the checklist at #59836).

@DanTup DanTup closed this as completed Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. feature-dot-shorthands Implementation of the dot shorthands feature. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

4 participants