Skip to content

NodeLintRegistry lacks addWildcardPattern. #60601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrhn opened this issue Apr 23, 2025 · 3 comments
Closed

NodeLintRegistry lacks addWildcardPattern. #60601

lrhn opened this issue Apr 23, 2025 · 3 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-plugin

Comments

@lrhn
Copy link
Member

lrhn commented Apr 23, 2025

The NodeLintRegitstry has an entry for each AST node/visitor of AstVisitor, except that it lacks one for the AST node WildcardPattern.

Presumably it was never added when wildcards were introduced.

There is a _forWildcardPattern list and a vistWildcardPattern visitor running through that list, just no function to add subscriptions to the list.

@lrhn lrhn added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-plugin labels Apr 23, 2025
@lrhn
Copy link
Member Author

lrhn commented Apr 23, 2025

(Here's an implementation, but I guess there needs to be some versioning shennanigans too: https://dart-review.googlesource.com/c/sdk/+/424042)

@bwilkerson
Copy link
Member

@scheglov @stereotype441 There should probably be a test to verify that all the pieces are added here so that this can't get out of sync without a warning.

@srawlins
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-plugin
Projects
None yet
Development

No branches or pull requests

3 participants