Flaky crash "runtime/vm/service_event.cc: 71: error: expected: isolate == nullptr || !Isolate::IsVMInternalIsolate(isolate) || (...)""

[alexmarkov]

/======================================================================================\
| pkg/vm_service/test/branch_coverage_test broke (Pass -> RuntimeError, expected Pass) |
\======================================================================================/

--- Command "vm" (took 09.000273s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & out\DebugX64\dart.exe --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\pkg\vm_service\test\branch_coverage_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: branch_coverage_test.dart�[0m

** Launching SERVICE_TEST_TESTEE=true out\DebugX64\dart.exe --disable-service-auth-codes --profiler --branch-coverage --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json --enable-vm-service:0 C:\b\s\w\ir\pkg\vm_service\test\branch_coverage_test.dart

>testee>out> The Dart VM service is listening on http://127.0.0.1:49832//
>testee>out> The Dart DevTools debugger and profiler is available at: http://127.0.0.1:49832/devtools/?uri=ws://127.0.0.1:49832/ws
>testee>err> ../../runtime/vm/service_event.cc: 71: error: expected: isolate == nullptr || !Isolate::IsVMInternalIsolate(isolate) || (Isolate::IsVMInternalIsolate(isolate) && (event_kind == ServiceEvent::kResume || event_kind == ServiceEvent::kNone || event_kind == ServiceEvent::kEmbedder || event_kind == ServiceEvent::kCpuSamples))
>testee>err> version=3.9.0-edge (main) (Unknown timestamp) on "windows_x64"
>testee>err> pid=3640, thread=4344, isolate_group=kernel-service(000002B2BDBAF020), isolate=kernel-service(000002B2BC39AAF0)
>testee>err> os=windows, arch=x64, comp=no, sim=no
>testee>err> isolate_instructions=0, vm_instructions=7ff7dc9ac040
>testee>err> fp=ba173fe150, sp=ba173fe128, pc=7ff7dd19ce0c
>testee>err>   pc 0x00007ff7dd19ce0c fp 0x000000ba173fe150 C:\b\s\w\ir\out\DebugX64\dart.exe+0x7fce0c
>testee>err> -- End of DumpStackTrace
>testee>err>   pc 0x0000000000000000 fp 0x000000ba173feb80 sp 0x0000000000000000 [Stub] CallBootstrapNative
>testee>err>   pc 0x000002b2c0edc0a1 fp 0x000000ba173febb8 sp 0x000000ba173feb90 [Unoptimized] _postTimerEvent@1026248
>testee>err>   pc 0x000002b2c0edb36d fp 0x000000ba173fec40 sp 0x000000ba173febc8 [Unoptimized] _Timer@1026248._runTimers@1026248
>testee>err>   pc 0x000002b2c0ed9d10 fp 0x000000ba173fec78 sp 0x000000ba173fec50 [Unoptimized] _Timer@1026248._handleMessage@1026248
>testee>err>   pc 0x000002b2c0ed9b86 fp 0x000000ba173feca8 sp 0x000000ba173fec88 [Unoptimized] _Timer@1026248._handleMessage@1026248
>testee>err>   pc 0x000002b2c0ead6fa fp 0x000000ba173fed10 sp 0x000000ba173fecb8 [Unoptimized] [email protected]:call
>testee>err>   pc 0x000002b2c0eac50a fp 0x000000ba173fed68 sp 0x000000ba173fed20 [Unoptimized] _RawReceivePort@1026248._handleMessage@1026248
>testee>err>   pc 0x000002b2bbc838a0 fp 0x000000ba173fee90 sp 0x000000ba173fed78 [Stub] InvokeDartCode

stderr:
Unhandled exception:
Testee exited with unexpected exitCode: 1073741845
#0      _ServiceTesterRunner.run (file:///C:/b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:417:9)
<asynchronous suspension>
#1      runIsolateTests (file:///C:/b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:489:5)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-win-debug-x64 pkg/vm_service/test/branch_coverage_test

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8716788802729538321/+/u/test_results/ignored_flaky_test_failure_logs

Could be related to https://dart-review.googlesource.com/c/sdk/+/409500 which introduced _postTimerEvent.

/cc @derekxu16 @bkonyi