Skip to content

Commit 3ad544e

Browse files
authored
[MV3 Debug Extension] Remove isMV3Extension field from DevtoolsRequest (#1963)
1 parent c77043e commit 3ad544e

File tree

5 files changed

+43
-93
lines changed

5 files changed

+43
-93
lines changed

dwds/debug_extension_mv3/web/debug_session.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,7 @@ Future<bool> _connectToDwds({
275275
..instanceId = debugInfo.appInstanceId
276276
..contextId = dartAppContextId
277277
..tabUrl = tabUrl
278-
..uriOnly = true
279-
..isMv3Extension = true));
278+
..uriOnly = true));
280279
return true;
281280
}
282281

dwds/lib/data/devtools_request.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@ abstract class DevToolsRequest
4646
/// Only available on requests coming from the Dart Debug Extension. Is `null`
4747
/// for local debug service.
4848
bool? get uriOnly;
49-
50-
/// Whether or not the MV3 Dart Debug Extension sent the request. Is `null`
51-
/// for local debug service.
52-
///
53-
/// Only available on requests coming from the Dart Debug Extension.
54-
bool? get isMv3Extension;
5549
}
5650

5751
/// A response to a [DevToolsRequest].

dwds/lib/data/devtools_request.g.dart

Lines changed: 4 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/lib/src/handlers/dev_handler.dart

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -561,14 +561,10 @@ class DevHandler {
561561
// handle how to open it. Therefore return early before opening a new
562562
// tab or window:
563563
if (devToolsRequest.uriOnly ?? false) {
564-
// The MV3 extension is responsible for adding the IDE query
565-
// parameter to the DevTools URI.
566-
final devToolsUri = (devToolsRequest.isMv3Extension ?? false)
567-
? _constructDevToolsUri(encodedUri)
568-
: _constructDevToolsUri(
569-
encodedUri,
570-
ideQueryParam: 'ChromeDevTools',
571-
);
564+
final devToolsUri = _constructDevToolsUri(
565+
encodedUri,
566+
ideQueryParam: 'ChromeDevTools',
567+
);
572568
return extensionDebugger.sendEvent('dwds.devtoolsUri', devToolsUri);
573569
}
574570

dwds/lib/src/injected/client.js

Lines changed: 34 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)