fix(dpp): validate group required power to prevent invalid configurations (#2595)

Author: QuantumExplorer

packages/rs-dpp/src/data_contract/group/v0/mod.rs

@@ -1,6 +1,6 @@
 use crate::consensus::basic::data_contract::{
     GroupExceedsMaxMembersError, GroupMemberHasPowerOfZeroError, GroupMemberHasPowerOverLimitError,
-    GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError,
+    GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError, GroupRequiredPowerIsInvalidError,
     GroupTotalPowerLessThanRequiredError,
 };
 use crate::data_contract::group::accessors::v0::{GroupV0Getters, GroupV0Setters};
@@ -151,6 +151,13 @@ impl GroupMethodsV0 for GroupV0 {
             ));
         }
 
+        if self.required_power == 0 || self.required_power() > GROUP_POWER_LIMIT {
+            return Ok(SimpleConsensusValidationResult::new_with_error(
+                GroupRequiredPowerIsInvalidError::new(self.required_power, GROUP_POWER_LIMIT)
+                    .into(),
+            ));
+        }
+
         // If all validations pass, return an empty validation result
         Ok(SimpleConsensusValidationResult::new())
     }

packages/rs-dpp/src/errors/consensus/basic/basic_error.rs

@@ -11,10 +11,10 @@ use crate::consensus::basic::data_contract::{
     DataContractUniqueIndicesChangedError, DecimalsOverLimitError, DuplicateIndexError,
     DuplicateIndexNameError, GroupExceedsMaxMembersError, GroupMemberHasPowerOfZeroError,
     GroupMemberHasPowerOverLimitError, GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError,
-    GroupPositionDoesNotExistError, GroupTotalPowerLessThanRequiredError,
-    IncompatibleDataContractSchemaError, IncompatibleDocumentTypeSchemaError,
-    IncompatibleRe2PatternError, InvalidCompoundIndexError, InvalidDataContractIdError,
-    InvalidDataContractVersionError, InvalidDocumentTypeNameError,
+    GroupPositionDoesNotExistError, GroupRequiredPowerIsInvalidError,
+    GroupTotalPowerLessThanRequiredError, IncompatibleDataContractSchemaError,
+    IncompatibleDocumentTypeSchemaError, IncompatibleRe2PatternError, InvalidCompoundIndexError,
+    InvalidDataContractIdError, InvalidDataContractVersionError, InvalidDocumentTypeNameError,
     InvalidDocumentTypeRequiredSecurityLevelError, InvalidIndexPropertyTypeError,
     InvalidIndexedPropertyConstraintError, InvalidKeywordCharacterError,
     InvalidTokenBaseSupplyError, InvalidTokenDistributionFunctionDivideByZeroError,
@@ -557,6 +557,9 @@ pub enum BasicError {
 
     #[error(transparent)]
     MainGroupIsNotDefinedError(MainGroupIsNotDefinedError),
+
+    #[error(transparent)]
+    GroupRequiredPowerIsInvalidError(GroupRequiredPowerIsInvalidError),
 }
 
 impl From<BasicError> for ConsensusError {

packages/rs-dpp/src/errors/consensus/basic/data_contract/group_required_power_is_invalid_error.rs

@@ -0,0 +1,40 @@
+use crate::consensus::basic::BasicError;
+use crate::consensus::ConsensusError;
+use crate::data_contract::group::GroupRequiredPower;
+use crate::errors::ProtocolError;
+use bincode::{Decode, Encode};
+use platform_serialization_derive::{PlatformDeserialize, PlatformSerialize};
+use thiserror::Error;
+
+#[derive(
+    Debug, Error, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
+)]
+#[platform_serialize(unversioned)]
+#[error("The required group power {required_power} is invalid. It must be > 0 and <= {max_power}.")]
+pub struct GroupRequiredPowerIsInvalidError {
+    required_power: GroupRequiredPower,
+    max_power: GroupRequiredPower,
+}
+
+impl GroupRequiredPowerIsInvalidError {
+    pub fn new(required_power: GroupRequiredPower, max_power: GroupRequiredPower) -> Self {
+        Self {
+            required_power,
+            max_power,
+        }
+    }
+
+    pub fn required_power(&self) -> GroupRequiredPower {
+        self.required_power
+    }
+
+    pub fn max_power(&self) -> GroupRequiredPower {
+        self.max_power
+    }
+}
+
+impl From<GroupRequiredPowerIsInvalidError> for ConsensusError {
+    fn from(err: GroupRequiredPowerIsInvalidError) -> Self {
+        Self::BasicError(BasicError::GroupRequiredPowerIsInvalidError(err))
+    }
+}

packages/rs-dpp/src/errors/consensus/basic/data_contract/mod.rs

@@ -15,6 +15,7 @@ mod group_member_has_power_of_zero_error;
 mod group_member_has_power_over_limit_error;
 mod group_non_unilateral_member_power_has_less_than_required_power_error;
 mod group_position_does_not_exist_error;
+mod group_required_power_is_invalid_error;
 mod group_total_power_has_less_than_required_power_error;
 mod incompatible_data_contract_schema_error;
 mod incompatible_document_type_schema_error;
@@ -86,6 +87,7 @@ pub use group_member_has_power_of_zero_error::*;
 pub use group_member_has_power_over_limit_error::*;
 pub use group_non_unilateral_member_power_has_less_than_required_power_error::*;
 pub use group_position_does_not_exist_error::*;
+pub use group_required_power_is_invalid_error::*;
 pub use group_total_power_has_less_than_required_power_error::*;
 pub use incompatible_document_type_schema_error::*;
 pub use invalid_description_length_error::*;

packages/rs-dpp/src/errors/consensus/codes.rs

@@ -116,7 +116,6 @@ impl ErrorWithCode for BasicError {
             Self::InvalidKeywordCharacterError(_) => 10269,
             Self::InvalidKeywordLengthError(_) => 10270,
             Self::DecimalsOverLimitError(_) => 10271,
-            Self::MainGroupIsNotDefinedError(_) => 10272,
 
             // Group Errors: 10350-10399
             Self::GroupPositionDoesNotExistError(_) => 10350,
@@ -126,6 +125,8 @@ impl ErrorWithCode for BasicError {
             Self::GroupExceedsMaxMembersError(_) => 10354,
             Self::GroupMemberHasPowerOfZeroError(_) => 10355,
             Self::GroupMemberHasPowerOverLimitError(_) => 10356,
+            Self::MainGroupIsNotDefinedError(_) => 10357,
+            Self::GroupRequiredPowerIsInvalidError(_) => 10358,
 
             // Document Errors: 10400-10449
             Self::DataContractNotPresentError { .. } => 10400,

packages/wasm-dpp/src/errors/consensus/consensus_error.rs

@@ -61,7 +61,7 @@ use dpp::consensus::state::data_trigger::DataTriggerError::{
   DataTriggerConditionError, DataTriggerExecutionError, DataTriggerInvalidResultError,
 };
 use wasm_bindgen::{JsError, JsValue};
-use dpp::consensus::basic::data_contract::{ContestedUniqueIndexOnMutableDocumentTypeError, ContestedUniqueIndexWithUniqueIndexError, DataContractTokenConfigurationUpdateError, DecimalsOverLimitError, DuplicateKeywordsError, GroupExceedsMaxMembersError, GroupMemberHasPowerOfZeroError, GroupMemberHasPowerOverLimitError, GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError, GroupPositionDoesNotExistError, GroupTotalPowerLessThanRequiredError, InvalidDescriptionLengthError, InvalidDocumentTypeRequiredSecurityLevelError, InvalidKeywordCharacterError, InvalidKeywordLengthError, InvalidTokenBaseSupplyError, InvalidTokenDistributionFunctionDivideByZeroError, InvalidTokenDistributionFunctionIncoherenceError, InvalidTokenDistributionFunctionInvalidParameterError, InvalidTokenDistributionFunctionInvalidParameterTupleError, InvalidTokenLanguageCodeError, InvalidTokenNameCharacterError, InvalidTokenNameLengthError, MainGroupIsNotDefinedError, NewTokensDestinationIdentityOptionRequiredError, NonContiguousContractGroupPositionsError, NonContiguousContractTokenPositionsError, TokenPaymentByBurningOnlyAllowedOnInternalTokenError, TooManyKeywordsError, UnknownDocumentActionTokenEffectError, UnknownDocumentCreationRestrictionModeError, UnknownGasFeesPaidByError, UnknownSecurityLevelError, UnknownStorageKeyRequirementsError, UnknownTradeModeError, UnknownTransferableTypeError};
+use dpp::consensus::basic::data_contract::{ContestedUniqueIndexOnMutableDocumentTypeError, ContestedUniqueIndexWithUniqueIndexError, DataContractTokenConfigurationUpdateError, DecimalsOverLimitError, DuplicateKeywordsError, GroupExceedsMaxMembersError, GroupMemberHasPowerOfZeroError, GroupMemberHasPowerOverLimitError, GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError, GroupPositionDoesNotExistError, GroupRequiredPowerIsInvalidError, GroupTotalPowerLessThanRequiredError, InvalidDescriptionLengthError, InvalidDocumentTypeRequiredSecurityLevelError, InvalidKeywordCharacterError, InvalidKeywordLengthError, InvalidTokenBaseSupplyError, InvalidTokenDistributionFunctionDivideByZeroError, InvalidTokenDistributionFunctionIncoherenceError, InvalidTokenDistributionFunctionInvalidParameterError, InvalidTokenDistributionFunctionInvalidParameterTupleError, InvalidTokenLanguageCodeError, InvalidTokenNameCharacterError, InvalidTokenNameLengthError, MainGroupIsNotDefinedError, NewTokensDestinationIdentityOptionRequiredError, NonContiguousContractGroupPositionsError, NonContiguousContractTokenPositionsError, TokenPaymentByBurningOnlyAllowedOnInternalTokenError, TooManyKeywordsError, UnknownDocumentActionTokenEffectError, UnknownDocumentCreationRestrictionModeError, UnknownGasFeesPaidByError, UnknownSecurityLevelError, UnknownStorageKeyRequirementsError, UnknownTradeModeError, UnknownTransferableTypeError};
 use dpp::consensus::basic::document::{ContestedDocumentsTemporarilyNotAllowedError, DocumentCreationNotAllowedError, DocumentFieldMaxSizeExceededError, MaxDocumentsTransitionsExceededError, MissingPositionsInDocumentTypePropertiesError};
 use dpp::consensus::basic::group::GroupActionNotAllowedOnTransitionError;
 use dpp::consensus::basic::identity::{DataContractBoundsNotPresentError, DisablingKeyIdAlsoBeingAddedInSameTransitionError, InvalidIdentityCreditWithdrawalTransitionAmountError, InvalidIdentityUpdateTransitionDisableKeysError, InvalidIdentityUpdateTransitionEmptyError, TooManyMasterPublicKeyError, WithdrawalOutputScriptNotAllowedWhenSigningWithOwnerKeyError};
@@ -810,6 +810,9 @@ fn from_basic_error(basic_error: &BasicError) -> JsValue {
         BasicError::MainGroupIsNotDefinedError(e) => {
             generic_consensus_error!(MainGroupIsNotDefinedError, e).into()
         }
+        BasicError::GroupRequiredPowerIsInvalidError(e) => {
+            generic_consensus_error!(GroupRequiredPowerIsInvalidError, e).into()
+        }
     }
 }