Skip to content

Commit d3f0232

Browse files
authored
Merge branch 'main' into feat/rt-compio
2 parents 8309c83 + 8b21d7e commit d3f0232

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/commit-message-check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@ jobs:
2121
excludeDescription: 'true' # optional: this excludes the description body of a pull request
2222
excludeTitle: 'true' # optional: this excludes the title of a pull request
2323
accessToken: ${{ secrets.GITHUB_TOKEN }}
24-
pattern: '^(DataChange:|Change:|Feature:|Improve:|Perf:|Dep:|Doc:|Test:|CI:|Refactor:|Fix:|Fixdoc:|Fixup:|Merge|BumpVer:|Chore:|fix:|feat:|perf:|refactor:|test:|docs:|deps:|chore:|ci:|Build\(deps\):) .+$'
24+
pattern: '^(DataChange:|Change:|change:|Feature:|Improve:|Perf:|Dep:|Doc:|Test:|CI:|Refactor:|Fix:|Fixdoc:|Fixup:|Merge|BumpVer:|Chore:|fix:|feat:|perf:|refactor:|test:|docs:|deps:|chore:|ci:|Build\(deps\):) .+$'
2525
flags: 'gm'
2626
error: |
2727
Subject line has to contain a commit type, e.g.: "Change: blabla" or a merge commit e.g.: "Merge xxx".
2828
Valid types are:
2929
DataChange - Persistent data change
3030
Change - API breaking change
31+
change - API breaking change
3132
Feature - API compatible new feature
3233
feat - API compatible new feature
3334
Improve - Become better without functional changes

openraft/src/raft/mod.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -571,12 +571,13 @@ where C: RaftTypeConfig
571571
/// - `Ok((read_log_id, last_applied_log_id))` on successful confirmation that the node is the
572572
/// leader. `read_log_id` represents the log id up to which the state machine should apply to
573573
/// ensure a linearizable read.
574-
/// - `Err(RaftError<CheckIsLeaderError>)` if it detects a higher term, or if it fails to
575-
/// communicate with a quorum of followers.
574+
/// - `Err(RaftError<CheckIsLeaderError>)` if this node fail to ensure its leadership, for
575+
/// example, it detects a higher term, or fails to communicate with a quorum.
576576
///
577-
/// The caller should then wait for `last_applied_log_id` to catch up, which can be done by
578-
/// subscribing to [`Raft::metrics`] and waiting for `last_applied_log_id` to
579-
/// reach `read_log_id`.
577+
/// Once returned, the caller should wait for the state machine to apply entries up to
578+
/// `read_log_id`. This can be done by using the [`wait()`] as shown in the example
579+
/// below, or by directly monitoring `last_applied` in [`Raft::metrics`] until it reaches or
580+
/// exceeds `read_log_id`.
580581
///
581582
/// # Examples
582583
/// ```ignore
@@ -589,6 +590,8 @@ where C: RaftTypeConfig
589590
/// The comparison `read_log_id > applied_log_id` would also be valid in the above example.
590591
///
591592
/// See: [Read Operation](crate::docs::protocol::read)
593+
///
594+
/// [`wait()`]: Raft::wait
592595
#[tracing::instrument(level = "debug", skip(self))]
593596
pub async fn get_read_log_id(
594597
&self,
@@ -639,6 +642,7 @@ where C: RaftTypeConfig
639642
/// `_ff` means fire and forget.
640643
///
641644
/// It is same as [`Raft::client_write`] but does not wait for the response.
645+
#[since(version = "0.10.0")]
642646
#[tracing::instrument(level = "debug", skip(self, app_data))]
643647
pub async fn client_write_ff(&self, app_data: C::D) -> Result<ResponderReceiverOf<C>, Fatal<C>> {
644648
let (app_data, tx, rx) = ResponderOf::<C>::from_app_data(app_data);

0 commit comments

Comments
 (0)