Skip to content

Commit 11c05af

Browse files
chore: add wip errata doc for v2 (terraform-google-modules#405)
* chore: add wip errata doc for v1 * Apply suggestions from code review Co-authored-by: Daniel Andrade <[email protected]> * Update ERRATA.md Co-authored-by: Daniel Andrade <[email protected]>
1 parent fd5329c commit 11c05af

File tree

1 file changed

+27
-6
lines changed

1 file changed

+27
-6
lines changed

ERRATA.md

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,40 @@
1-
## Errata Summary
1+
# Errata Summary
22
This is an overview of the delta between the example foundation repository and the [Google Cloud security foundations guide](https://services.google.com/fh/files/misc/google-cloud-security-foundations-guide.pdf), including code discrepancies and notes on future automation. This document will be updated as new code is merged.
33

4+
## 2.x [WIP]
45
### Code Discrepancies
56

6-
##### Labeling
7+
#### Labeling
78
- The guide defines vpc-type for shared, service, float, nic, and peer projects. It does not define a vpc-type for Jenkins agents (vpc-b-jenkinsagents), the DNS Hub (vpc-dns-hub) and projects created in 4-projects.
8-
This will be addressed in the next version of the whitepaper.
9+
This will be addressed in the next version of the blueprint guide.
910

10-
##### Naming
11+
#### Naming
12+
- The Service Account naming is not aligned to the blueprint guide. Naming will be modified accordingly in a future release.
13+
- The infrastructure pipeline project naming (`prj-buN-c-infra-pipeline`) is not aligned to the blueprint guide(`prj-buN-c-sample-infra-pipeline`). Naming will be modified accordingly in a future release.
14+
15+
#### Networking
16+
- The “allow-windows-activation” rule that exists in the code is not explicitly called out in the guide.
17+
18+
#### Notes
19+
- The BigQuery Log Detection solution, described in Section 10 will be integrated in a future release.
20+
- Splunk log integration will be integrated in a future release.
21+
- Cloud Asset Inventory will be integrated in a future release.
22+
- The unallocated IP address space in the Shared VPC networks, described in Section 7.3, is currently being used by Private Service Networking in this release.
23+
24+
## [1.x](https://github.com/terraform-google-modules/terraform-example-foundation/releases/tag/v1.0.0)
25+
### Code Discrepancies
26+
27+
#### Labeling
28+
- The guide defines vpc-type for shared, service, float, nic, and peer projects. It does not define a vpc-type for Jenkins agents (vpc-b-jenkinsagents), the DNS Hub (vpc-dns-hub) and projects created in 4-projects.
29+
This will be addressed in the next version of the blueprint guide.
30+
31+
#### Naming
1132
- The Service Account & Storage bucket naming are not aligned to the blueprint guide. Naming will be modified accordingly in a future release.
1233

13-
##### Pre-deployment Check
34+
#### Pre-deployment Check
1435
- Terraform Validator, described in Section 5.2, is not implemented in the Cloud Build and Jenkins pipelines, but will be integrated in a future release.
1536

16-
### Notes
37+
#### Notes
1738
- The BigQuery Log Detection solution, described in Section 10 will be integrated in a future release.
1839
- Splunk log integration will be integrated in a future release.
1940
- Cloud Asset Inventory will be integrated in a future release.

0 commit comments

Comments
 (0)