Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: discourse/discourse
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: davidmiller/discourse
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 29, 2016

  1. change 'cause' to 'because' for the reason that it is regarded as bet… 

    …ter English grammar

Apologies if this seems a trivial pull request, but I recently noticed that the text in the footer of email I am getting as Admin of my Discourse instance says "You are receiving these emails *cause* you have enabled mailing list mode". I would suggest that this should say "You are receiving these emails *because* you have enabled mailing list mode", which is regarded as better English grammar and more professional sounding.
    @pacharanero
    pacharanero authored Jul 29, 2016
    Configuration menu
    Copy the full SHA
    754b019 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from pacharanero/change-'cause'-to-'because' 

    change 'cause' to 'because' for the reason that it is better English grammar
    @pacharanero
    pacharanero authored Jul 29, 2016
    Configuration menu
    Copy the full SHA
    23ca444 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2016

  1. first attempt at a more automated and user-friendly googlegroup migra… 

    …tion script for discourse
    @pacharanero
    pacharanero committed Jul 30, 2016
    Configuration menu
    Copy the full SHA
    060c142 View commit details
    Browse the repository at this point in the history

  2. All in one google group scraping program (#2) 

    * convert largely functional script into something more resembling the other migration/import scripts with at least an attempt at OO

* working first draft of a working ImportScripts::GoogleGroups subclass

* here have some more code
    @pacharanero
    pacharanero authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    7dd3b13 View commit details
    Browse the repository at this point in the history

  3. minor changes to instructions in header

    @pacharanero
    pacharanero committed Jul 30, 2016
    Configuration menu
    Copy the full SHA
    644dc85 View commit details
    Browse the repository at this point in the history

  4. removed 2 debugging 'puts'es

    @pacharanero
    pacharanero authored Jul 30, 2016
    Configuration menu
    Copy the full SHA
    a223b7d View commit details
    Browse the repository at this point in the history
Loading