Improve bike handling for highway=living_street (graphhopper#3032)

* Improve bike handling for highway=living_street

* Run bicycles at tagged maxspeed if allowed and possible

* Fix test

* Revert allow maxspeed if possible and only increase living_street highway speed to 6 for bicycles as suggested in review

* Fix test

Author: ratrun

core/src/main/java/com/graphhopper/routing/util/parsers/BikeCommonAverageSpeedParser.java

@@ -68,7 +68,7 @@ protected BikeCommonAverageSpeedParser(DecimalEncodedValue speedEnc, EnumEncoded
         setSurfaceSpeed("sand", PUSHING_SECTION_SPEED);
         setSurfaceSpeed("wood", PUSHING_SECTION_SPEED);
 
-        setHighwaySpeed("living_street", PUSHING_SECTION_SPEED);
+        setHighwaySpeed("living_street", 6);
         setHighwaySpeed("steps", MIN_SPEED);
 
         setHighwaySpeed("cycleway", 18);
@@ -156,10 +156,9 @@ else if (way.hasTag("bicycle", "yes"))
         if (way.hasTag("surface") && surfaceSpeed == null
                 || way.hasTag("bicycle", "dismount")
                 || way.hasTag("railway", "platform")
-                || pushingRestriction && !way.hasTag("bicycle", INTENDED)) {
+                || pushingRestriction && !way.hasTag("bicycle", INTENDED)
+                || way.hasTag("service")) {
             speed = PUSHING_SECTION_SPEED;
-        } else if (way.hasTag("service")) {
-            speed = highwaySpeeds.get("living_street");
         } else if ("track".equals(highwayValue) ||
                 "bridleway".equals(highwayValue) ) {
             if (surfaceSpeed != null)

core/src/test/java/com/graphhopper/routing/util/parsers/BikeTagParserTest.java

@@ -76,6 +76,10 @@ public void testSpeedAndPriority() {
         way.setTag("scenic", "yes");
         assertPriorityAndSpeed(AVOID_MORE, 18, way);
 
+        way.clearTags();
+        way.setTag("highway", "living_street");
+        assertPriorityAndSpeed(UNCHANGED, 6, way);
+
         // Pushing section: this is fine as we obey the law!
         way.clearTags();
         way.setTag("highway", "footway");