Fix some new issues found in the latest version of ansible-lint.

Author: geerlingguy

molecule/default/yaml-lint.yml

@@ -2,5 +2,5 @@
 extends: default
 rules:
   line-length:
-    max: 150
+    max: 120
     level: warning

tasks/configure.yml

@@ -65,7 +65,9 @@
   args:
     creates: "{{ mysql_log_error }}"
     warn: false
-  when: mysql_log == "" and mysql_log_error != ""
+  when:
+    - not mysql_log
+    - mysql_log_error
 
 - name: Set ownership on error log file (if configured).
   file:
@@ -74,7 +76,9 @@
     owner: mysql
     group: "{{ mysql_log_file_group }}"
     mode: 0640
-  when: mysql_log == "" and mysql_log_error != ""
+  when:
+    - not mysql_log
+    - mysql_log_error
 
 - name: Ensure MySQL is started and enabled on boot.
   service: "name={{ mysql_daemon }} state=started enabled={{ mysql_enabled_on_startup }}"

tasks/replication.yml

@@ -6,10 +6,10 @@
     password: "{{ mysql_replication_user.password }}"
     priv: "{{ mysql_replication_user.priv | default('*.*:REPLICATION SLAVE,REPLICATION CLIENT') }}"
     state: present
-  when: >
-    (mysql_replication_role == 'master')
-    and mysql_replication_user
-    and (mysql_replication_master != '')
+  when:
+    - mysql_replication_role == 'master'
+    - mysql_replication_user
+    - mysql_replication_master
 
 - name: Check slave replication status.
   mysql_replication:
@@ -18,18 +18,18 @@
     login_password: "{{ mysql_replication_user.password }}"
   ignore_errors: true
   register: slave
-  when: >
-    mysql_replication_role == 'slave'
-    and (mysql_replication_master != '')
+  when:
+    - mysql_replication_role == 'slave'
+    - mysql_replication_master
 
 - name: Check master replication status.
   mysql_replication: mode=getmaster
   delegate_to: "{{ mysql_replication_master }}"
   register: master
-  when: >
-    ((slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed))
-    and (mysql_replication_role == 'slave')
-    and (mysql_replication_master != '')
+  when:
+    - (slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed)
+    - mysql_replication_role == 'slave'
+    - mysql_replication_master
 
 - name: Configure replication on the slave.
   mysql_replication:
@@ -40,15 +40,15 @@
     master_log_file: "{{ master.File }}"
     master_log_pos: "{{ master.Position }}"
   ignore_errors: true
-  when: >
-    ((slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed))
-    and (mysql_replication_role == 'slave')
-    and (mysql_replication_master != '')
-    and mysql_replication_user
+  when:
+    - (slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed)
+    - mysql_replication_role == 'slave'
+    - mysql_replication_master
+    - mysql_replication_user
 
 - name: Start replication.
   mysql_replication: mode=startslave
-  when: >
-    ((slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed))
-    and (mysql_replication_role == 'slave')
-    and (mysql_replication_master != '')
+  when:
+    - (slave.Is_Slave is defined and not slave.Is_Slave) or (slave.Is_Slave is not defined and slave is failed)
+    - mysql_replication_role == 'slave'
+    - mysql_replication_master

tasks/secure-installation.yml

@@ -26,7 +26,11 @@
   changed_when: false
 
 - name: Get list of hosts for the root user.
-  command: mysql -NBe "SELECT Host FROM mysql.user WHERE User = '{{ mysql_root_username }}' ORDER BY (Host='localhost') ASC"
+  command: mysql -NBe
+    "SELECT Host
+    FROM mysql.user
+    WHERE User = '{{ mysql_root_username }}'
+    ORDER BY (Host='localhost') ASC"
   register: mysql_root_hosts
   changed_when: false
   check_mode: false
@@ -38,7 +42,8 @@
 - name: Update MySQL root password for localhost root account (5.7.x).
   shell: >
     mysql -u root -NBe
-    'ALTER USER "{{ mysql_root_username }}"@"{{ item }}" IDENTIFIED WITH mysql_native_password BY "{{ mysql_root_password }}";'
+    'ALTER USER "{{ mysql_root_username }}"@"{{ item }}"
+    IDENTIFIED WITH mysql_native_password BY "{{ mysql_root_password }}";'
   with_items: "{{ mysql_root_hosts.stdout_lines|default([]) }}"
   when: >
     ((mysql_install_packages | bool) or mysql_root_password_update)

tasks/setup-Archlinux.yml

@@ -10,3 +10,4 @@
 - name: Run mysql_install_db if MySQL packages were changed.
   command: mysql_install_db --user=mysql --basedir=/usr --datadir=/var/lib/mysql
   when: arch_mysql_install_packages.changed
+  tags: ['skip_ansible_lint']

tasks/setup-Debian.yml

@@ -5,11 +5,12 @@
 
 - name: Update apt cache if MySQL is not yet installed.
   apt: update_cache=yes
-  when: mysql_installed.stat.exists == false
+  when: not mysql_installed.stat.exists
 
 - name: Determine required MySQL Python libraries.
   set_fact:
     deb_mysql_python_package: "{% if 'python3' in ansible_python_interpreter|default('') %}python3-mysqldb{% else %}python-mysqldb{% endif %}"
+  tags: ['skip_ansible_lint']
 
 - name: Ensure MySQL Python libraries are installed.
   apt: "name={{ deb_mysql_python_package }} state=present"
@@ -22,11 +23,11 @@
 # mysql and remove the logfiles in case the user set a custom log file size.
 - name: Ensure MySQL is stopped after initial install.
   service: "name={{ mysql_daemon }} state=stopped"
-  when: mysql_installed.stat.exists == false
+  when: not mysql_installed.stat.exists
 
 - name: Delete innodb log files created by apt package after initial install.
-  file: path={{ mysql_datadir }}/{{item}} state=absent
+  file: path={{ mysql_datadir }}/{{ item }} state=absent
   with_items:
-    - "ib_logfile0"
-    - "ib_logfile1"
-  when: mysql_installed.stat.exists == false
+    - ib_logfile0
+    - ib_logfile1
+  when: not mysql_installed.stat.exists