Skip to content

Commit b3b4020

Browse files
committed
fix new cases with const and let
1 parent 62afdb2 commit b3b4020

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

README.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -583,11 +583,11 @@ Array.prototype.diff = function(comparisonArray) {
583583
const values = [];
584584
const hash = {};
585585

586-
for (let i of comparisonArray) {
586+
for (const i of comparisonArray) {
587587
hash[i] = true;
588588
}
589589

590-
for (let i of this) {
590+
for (const i of this) {
591591
if (!hash[i]) {
592592
values.push(i);
593593
}
@@ -608,11 +608,11 @@ class SuperArray extends Array {
608608
const values = [];
609609
const hash = {};
610610

611-
for (let i of comparisonArray) {
611+
for (const i of comparisonArray) {
612612
hash[i] = true;
613613
}
614614

615-
for (let i of this) {
615+
for (const i of this) {
616616
if (!hash[i]) {
617617
values.push(i);
618618
}
@@ -1150,12 +1150,12 @@ function renderLargeRectangles(rectangles) {
11501150
rectangles.forEach((rectangle) => {
11511151
rectangle.setWidth(4);
11521152
rectangle.setHeight(5);
1153-
let area = rectangle.getArea(); // BAD: Will return 25 for Square. Should be 20.
1153+
const area = rectangle.getArea(); // BAD: Will return 25 for Square. Should be 20.
11541154
rectangle.render(area);
11551155
})
11561156
}
11571157

1158-
let rectangles = [new Rectangle(), new Rectangle(), new Square()];
1158+
const rectangles = [new Rectangle(), new Rectangle(), new Square()];
11591159
renderLargeRectangles(rectangles);
11601160
```
11611161
@@ -1932,7 +1932,7 @@ class PerformanceReview {
19321932
}
19331933
}
19341934

1935-
let review = new PerformanceReview(user);
1935+
const review = new PerformanceReview(user);
19361936
review.perfReview();
19371937
```
19381938
@@ -1971,7 +1971,7 @@ class PerformanceReview {
19711971
}
19721972
}
19731973

1974-
let review = new PerformanceReview(employee);
1974+
const review = new PerformanceReview(employee);
19751975
review.perfReview();
19761976
```
19771977
@@ -2072,7 +2072,7 @@ proper indentation and formatting give the visual structure to your code.
20722072
////////////////////////////////////////////////////////////////////////////////
20732073
// Scope Model Instantiation
20742074
////////////////////////////////////////////////////////////////////////////////
2075-
const $scope.model = {
2075+
$scope.model = {
20762076
menu: 'foo',
20772077
nav: 'bar'
20782078
};
@@ -2087,7 +2087,7 @@ const actions = function() {
20872087
20882088
**Good**:
20892089
```javascript
2090-
const $scope.model = {
2090+
$scope.model = {
20912091
menu: 'foo',
20922092
nav: 'bar'
20932093
};

0 commit comments

Comments
 (0)