chore: upgrade rusty_v8 to 0.98.2 (#835)

Includes:
- denoland/rusty_v8#1532
- denoland/rusty_v8#1533

Closes #834

Author: bartlomieju

Cargo.lock

@@ -24,7 +24,7 @@ deno_ops = { version = "0.172.0", path = "./ops" }
 serde_v8 = { version = "0.205.0", path = "./serde_v8" }
 deno_core_testing = { path = "./testing" }
 
-v8 = { version = "0.98.1", default-features = false }
+v8 = { version = "0.98.2", default-features = false }
 deno_ast = { version = "=0.40.0", features = ["transpiling"] }
 deno_unsync = "0.3.10"
 deno_core_icudata = "0.0.73"

Cargo.toml

@@ -360,7 +360,7 @@ to_v8!(RustToV8Marker<ArrayBufferMarker, Box<[u8]>>: |buf, scope| {
 });
 to_v8_fallible!(Box<[u8]>: |buf, scope| {
   let len = buf.len();
-  let ab = unsafe { v8::Local::cast(RustToV8Marker::<ArrayBufferMarker, _>::from(buf).to_v8(scope)) };
+  let ab = unsafe { v8::Local::cast_unchecked(RustToV8Marker::<ArrayBufferMarker, _>::from(buf).to_v8(scope)) };
   v8::Uint8Array::new(scope, ab, 0, len).ok_or_else(|| serde_v8::Error::Message("failed to allocate array".into()))
 });
 to_v8!(RustToV8Marker<ArrayBufferMarker, Vec<u8>>: |value, scope| {
@@ -389,7 +389,7 @@ to_v8!(RustToV8Marker<ArrayBufferMarker, BytesMut>: |value, scope| {
 });
 to_v8_fallible!(BytesMut: |buf, scope| {
   let len = buf.len();
-  let ab = unsafe { v8::Local::cast(RustToV8Marker::<ArrayBufferMarker, _>::from(buf).to_v8(scope)) };
+  let ab = unsafe { v8::Local::cast_unchecked(RustToV8Marker::<ArrayBufferMarker, _>::from(buf).to_v8(scope)) };
   v8::Uint8Array::new(scope, ab, 0, len).ok_or_else(|| serde_v8::Error::Message("failed to allocate array".into()))
 });
 

core/runtime/ops_rust_to_v8.rs

@@ -170,7 +170,7 @@ pub(crate) fn generate_dispatch_async(
         let info: &'s _ = unsafe { &*#info };
         let args = deno_core::v8::FunctionCallbackArguments::from_function_callback_info(info);
         let #opctx: &'s _ = unsafe {
-          &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
+          &*(deno_core::v8::Local::<deno_core::v8::External>::cast_unchecked(args.data()).value()
             as *const deno_core::_ops::OpCtx)
         };
         deno_core::_ops::dispatch_metrics_async(#opctx, deno_core::_ops::OpMetricsEvent::Dispatched);

ops/op2/dispatch_async.rs

@@ -443,7 +443,7 @@ pub(crate) fn generate_dispatch_fast(
     generator_state.needs_fast_api_callback_options = true;
     gs_quote!(generator_state(opctx, fast_api_callback_options) => {
       let #opctx: &'s _ = unsafe {
-        &*(deno_core::v8::Local::<deno_core::v8::External>::cast(unsafe { #fast_api_callback_options.data.data }).value()
+        &*(deno_core::v8::Local::<deno_core::v8::External>::cast_unchecked(unsafe { #fast_api_callback_options.data.data }).value()
             as *const deno_core::_ops::OpCtx)
       };
     })
@@ -531,7 +531,7 @@ pub(crate) fn generate_dispatch_fast(
       let #fast_api_callback_options: &'s mut _ =
         unsafe { &mut *#fast_api_callback_options };
       let opctx: &'s _ = unsafe {
-          &*(deno_core::v8::Local::<deno_core::v8::External>::cast(
+          &*(deno_core::v8::Local::<deno_core::v8::External>::cast_unchecked(
             unsafe { #fast_api_callback_options.data.data }
           ).value() as *const deno_core::_ops::OpCtx)
       };

ops/op2/dispatch_fast.rs

@@ -171,7 +171,7 @@ pub(crate) fn generate_dispatch_slow(
         let info: &'s _ = unsafe { &*#info };
         let args = deno_core::v8::FunctionCallbackArguments::from_function_callback_info(info);
         let #opctx: &'s _ = unsafe {
-          &*(deno_core::v8::Local::<deno_core::v8::External>::cast(args.data()).value()
+          &*(deno_core::v8::Local::<deno_core::v8::External>::cast_unchecked(args.data()).value()
               as *const deno_core::_ops::OpCtx)
         };
 
@@ -220,7 +220,7 @@ pub(crate) fn with_opctx(generator_state: &mut GeneratorState) -> TokenStream {
   generator_state.needs_args = true;
   gs_quote!(generator_state(opctx, fn_args) =>
     (let #opctx: &'s _ = unsafe {
-    &*(deno_core::v8::Local::<deno_core::v8::External>::cast(#fn_args.data()).value()
+    &*(deno_core::v8::Local::<deno_core::v8::External>::cast_unchecked(#fn_args.data()).value()
         as *const deno_core::_ops::OpCtx)
     };)
   )