dependency resolution has changed

[dannysauer]

(edit: this is not what's happening - #2014 (comment) is)

I have a core project, and three projects which depend on core. Today I noticed that making a change to one of the "sub projects" seems to be causing "core" to replan, and then that (presumably) causes the other two dependent projects to be planned.

It basically appears as if dependencies are being treated as bidirecitonal, such that any project in the dependency tree causes the whole tree to replan. I'm positive that's new, but I don't know exactly how new. I have a PR from June 17 where the subproject was changed and only the affected subproject was replanned. Then today (July 8) is the first day with a planned PR where only the subproject was changed, but the whole tree was planned. So I can at least narrow the window down to sometime in that 3-week period. :)

[dannysauer]

Here's my current digger.yaml (missing a couple of projects which aren't related but also are kinda secret):

---
auto_merge: true
auto_merge_strategy: rebase

projects:
- name: bootstrap
  dir: projects/aws-bootstrap
  opentofu: true
  include_patterns:
    - ../../.tool-versions
    - ../../.github/workflows/digger_*.yml
- name: access-control
  dir: projects/access-control
  opentofu: true
  include_patterns:
    - ../../.tool-versions
    - ../../.github/workflows/digger_*.yml
    - ./**  # temporary workaround for https://github.com/diggerhq/digger/pull/1989/files change
- name: infra-k8s
  dir: projects/infra-k8s
  opentofu: true
  depends_on:
    - infra-core # for DNS zone creation
  include_patterns:
    - ../../.tool-versions
    - ../../.github/workflows/digger_*.yml
    - ../../modules/loki
    - ./**  # temporary workaround for https://github.com/diggerhq/digger/pull/1989/files change
- name: infra-core
  dir: projects/infra-core
  opentofu: true
  include_patterns:
    - ../../.tool-versions
    - ../../.github/workflows/digger_*.yml
    - ../../modules/dns
    - ../../modules/site
    - ./**  # temporary workaround for https://github.com/diggerhq/digger/pull/1989/files change
- name: github
  dir: projects/github
  opentofu: true
  include_patterns:
    - ../../.tool-versions
    - ../../.github/workflows/digger_*.yml
    - ./**  # temporary workaround for https://github.com/diggerhq/digger/pull/1989/files change

[dannysauer]

The workaround lines:

    - ./**  # temporary workaround for https://github.com/diggerhq/digger/pull/1989/files change

Those were added on June 24, which is in the middle of when this started happening. So now I suspect that this might not be the bug I thought. The intention was for those to recursively include any files in the current project directory. Is ** perhaps matching .. in the directory listing, facilitating the check walking up the tree? Or am I perhaps doing something else wrong here? :D

[dannysauer]

To be clear, the four with the "temporary workaround" line are the four which are getting replanned every time, and the other projects are working as before. I thought I had added dependencies between the other two and infra-core, but looking at the config now, I clearly did not. So it's definitely not a dependency issue like I originally thought. Whoops. :D

[dannysauer]

Well, TIL that the include paths are relative to the repository root, not the project root. I'm not sure if I'm happy about this or unhappy. 🤣

But it does explain why ./** was matching. When are we getting the recurse option? ;)

Closing, as this isn't a bug.

[motatoes]

Actually I think it should be relative to project directory indeed, if you are seeing otherwise then this is unexpected, I will dig into it further!