Optimise RelationConnection.has_next_page with exists? for ActiveRecord and record.empty?

Author: newtonry

lib/graphql/relay/relation_connection.rb

@@ -23,9 +23,21 @@ def cursor_from_node(item)
         end
       end
 
+      def record_exists?(record)
+        if(defined?(ActiveRecord::Relation) && record.is_a?(ActiveRecord::Relation))
+          record.exists?
+        else
+          !record.empty?
+        end
+      end
+
       def has_next_page
         if first
-          paged_nodes.length >= first && nodes.offset(first).exists?
+          if after
+            paged_nodes.length >= first && record_exists?(nodes.offset(first + offset_from_cursor(after)))
+          else
+            paged_nodes.length >= first && record_exists?(nodes.offset(first))
+          end
         elsif GraphQL::Relay::ConnectionType.bidirectional_pagination && last
           sliced_nodes_count >= last
         else