Skip to content

Commit 8f1a141

Browse files
committed
incorporate brad's comments
1 parent 1bbfde1 commit 8f1a141

File tree

7 files changed

+3
-7
lines changed

7 files changed

+3
-7
lines changed

certbot-apache/certbot_apache/configurator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ def _enable_ocsp_stapling(self, ssl_vhost, unused_options):
10801080
if not use_stapling_aug_path:
10811081
self.parser.add_dir(ssl_vhost.path, "SSLUseStapling", "on")
10821082

1083-
ssl_vhost_aug_path = parser.get_aug_path(ssl_vhost.filep)
1083+
ssl_vhost_aug_path = self._escape(parser.get_aug_path(ssl_vhost.filep))
10841084

10851085
# Check if there's an existing SSLStaplingCache directive.
10861086
stapling_cache_aug_path = self.parser.find_dir('SSLStaplingCache',

certbot-apache/certbot_apache/tests/configurator_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# pylint: disable=too-many-public-methods, protected-access
1+
# pylint: disable=too-many-public-methods
22
"""Test for certbot_apache.configurator."""
33
import os
44
import shutil
@@ -1188,6 +1188,7 @@ def test_aug_version(self):
11881188

11891189
class AugeasVhostsTest(util.ApacheTest):
11901190
"""Test vhosts with illegal names dependant on augeas version."""
1191+
# pylint: disable=protected-access
11911192

11921193
def setUp(self): # pylint: disable=arguments-differ
11931194
td = "debian_apache_2_4/augeas_vhosts"

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/000-default.conf

Lines changed: 0 additions & 1 deletion
This file was deleted.

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/certbot.conf

Lines changed: 0 additions & 1 deletion
This file was deleted.

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/encryption-example.conf

Lines changed: 0 additions & 1 deletion
This file was deleted.

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/mod_macro-example.conf

Lines changed: 0 additions & 1 deletion
This file was deleted.

certbot-apache/certbot_apache/tests/testdata/debian_apache_2_4/augeas_vhosts/apache2/sites-enabled/ocsp-ssl.conf

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)