Skip to content

Commit 0f4f923

Browse files
committed
Merge branch 'main' into gha-init
2 parents 5a23ae2 + f379254 commit 0f4f923

File tree

5 files changed

+1364
-246
lines changed

5 files changed

+1364
-246
lines changed

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ services:
2121
result:
2222
build: ./result
2323
# use nodemon rather than node for local dev
24-
command: nodemon server.js
24+
entrypoint: nodemon server.js
2525
depends_on:
2626
db:
2727
condition: service_healthy

result/Dockerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
FROM node:10-slim
1+
FROM node:18-slim
22

33
# add curl for healthcheck
44
RUN apt-get update \
55
&& apt-get install -y --no-install-recommends \
66
curl \
7+
tini \
78
&& rm -rf /var/lib/apt/lists/*
89

9-
# Add Tini for proper init of signals
10-
ENV TINI_VERSION v0.19.0
11-
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
12-
RUN chmod +x /tini
13-
1410
WORKDIR /app
1511

1612
# have nodemon available for local dev use (file watching)
@@ -25,7 +21,7 @@ RUN npm ci \
2521
COPY . .
2622

2723
ENV PORT 80
28-
2924
EXPOSE 80
3025

31-
CMD ["/tini", "--", "node", "server.js"]
26+
ENTRYPOINT ["/usr/bin/tini", "--"]
27+
CMD ["node", "server.js"]

0 commit comments

Comments
 (0)