Skip to content

Commit f0fb81f

Browse files
authored
Adding docker hub to push list (dockersamples#271)
* adding docker hub to push list * adding back arm builds to worker
1 parent 7e7445a commit f0fb81f

File tree

3 files changed

+10
-19
lines changed

3 files changed

+10
-19
lines changed

.github/workflows/call-docker-build-result.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,14 @@ jobs:
5252
### defaults to:
5353
image-names: |
5454
ghcr.io/dockersamples/example-voting-app-result
55-
# dockersamples/examplevotingapp_result
55+
dockersamples/examplevotingapp_result
5656
5757
### REQUIRED set rules for tagging images, based on special action syntax:
5858
### https://github.com/docker/metadata-action#tags-input
5959
### defaults to:
6060
tag-rules: |
6161
type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
6262
type=ref,event=pr
63-
type=ref,event=branch
64-
type=semver,pattern={{version}}
65-
type=raw,value=gha-${{ github.run_id }}
6663
6764
### path to where docker should copy files into image
6865
### defaults to root of repository (.)

.github/workflows/call-docker-build-vote.yaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,14 @@ jobs:
5252
### defaults to:
5353
image-names: |
5454
ghcr.io/dockersamples/example-voting-app-vote
55-
# dockersamples/examplevotingapp_vote
55+
dockersamples/examplevotingapp_vote
5656
5757
### REQUIRED set rules for tagging images, based on special action syntax:
5858
### https://github.com/docker/metadata-action#tags-input
5959
### defaults to:
60-
# tag-rules: |
61-
# type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
62-
# type=ref,event=pr
63-
# type=ref,event=branch
64-
# type=semver,pattern={{version}}
65-
# type=raw,value=gha-${{ github.run_id }}
60+
tag-rules: |
61+
type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
62+
type=ref,event=pr
6663
6764
### path to where docker should copy files into image
6865
### defaults to root of repository (.)

.github/workflows/call-docker-build-worker.yaml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,14 @@ jobs:
5252
### defaults to:
5353
image-names: |
5454
ghcr.io/dockersamples/example-voting-app-worker
55-
# dockersamples/examplevotingapp_worker
55+
dockersamples/examplevotingapp_worker
5656
5757
### REQUIRED set rules for tagging images, based on special action syntax:
5858
### https://github.com/docker/metadata-action#tags-input
5959
### defaults to:
60-
# tag-rules: |
61-
# type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
62-
# type=ref,event=pr
63-
# type=ref,event=branch
64-
# type=semver,pattern={{version}}
65-
# type=raw,value=gha-${{ github.run_id }}
60+
tag-rules: |
61+
type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
62+
type=ref,event=pr
6663
6764
### path to where docker should copy files into image
6865
### defaults to root of repository (.)
@@ -78,7 +75,7 @@ jobs:
7875
### other options: linux/amd64,linux/arm64,linux/arm/v7
7976
# FIXME worker arm/v7 support doesn't build in .net core 3.1 with QEMU
8077
# a fix would likely run the .net build on amd64 but with a target of arm/v7
81-
platforms: linux/amd64,linux/arm64
78+
platforms: linux/amd64,linux/arm64,linux/arm/v7
8279

8380
### Create a PR comment with image tags and labels
8481
### defaults to false

0 commit comments

Comments
 (0)