@@ -474,43 +474,43 @@ Heavily inspired by
474
474
475
475
- Always check for errors in callbacks
476
476
477
- ```javascript
478
- //bad
479
- database.get(' pokemons' , function (err, pokemons) {
480
- console.log(pokemons);
481
- });
482
-
483
- //good
484
- database.get(' drabonballs' , function (err, drabonballs) {
485
- if (err) {
486
- // handle the error somehow, maybe return with a callback
487
- return console.log(err);
488
- }
489
- console.log(drabonballs);
490
- });
491
- ```
477
+ ```javascript
478
+ //bad
479
+ database.get(' pokemons' , function (err, pokemons) {
480
+ console.log(pokemons);
481
+ });
482
+
483
+ //good
484
+ database.get(' drabonballs' , function (err, drabonballs) {
485
+ if (err) {
486
+ // handle the error somehow, maybe return with a callback
487
+ return console.log(err);
488
+ }
489
+ console.log(drabonballs);
490
+ });
491
+ ```
492
492
493
493
- Return on callbacks
494
- ```javascript
495
- //bad
496
- database.get(' drabonballs' , function (err, drabonballs) {
497
- if (err) {
498
- // if not return here
499
- console.log(err);
500
- }
501
- // this line will be executed as well
502
- console.log(drabonballs);
503
- });
504
-
505
- //good
506
- database.get(' drabonballs' , function (err, drabonballs) {
507
- if (err) {
508
- // handle the error somehow, maybe return with a callback
509
- return console.log(err);
510
- }
511
- console.log(drabonballs);
512
- });
513
- ```
494
+ ```javascript
495
+ //bad
496
+ database.get(' drabonballs' , function (err, drabonballs) {
497
+ if (err) {
498
+ // if not return here
499
+ console.log(err);
500
+ }
501
+ // this line will be executed as well
502
+ console.log(drabonballs);
503
+ });
504
+
505
+ //good
506
+ database.get(' drabonballs' , function (err, drabonballs) {
507
+ if (err) {
508
+ // handle the error somehow, maybe return with a callback
509
+ return console.log(err);
510
+ }
511
+ console.log(drabonballs);
512
+ });
513
+ ```
514
514
**[⬆ back to top](#table-of-contents)**
515
515
516
516
@@ -522,40 +522,40 @@ Heavily inspired by
522
522
down the entire process.
523
523
524
524
```javascript
525
- //bad
526
- function readPackageJson (callback) {
527
- fs.readFile(' package .json ' , function (err, file) {
528
- if (err) {
529
- throw err;
530
- }
531
- ...
532
- });
533
- }
534
- //good
535
- function readPackageJson (callback) {
536
- fs.readFile(' package .json ' , function (err, file) {
537
- if (err) {
538
- return callback(err);
539
- }
540
- ...
541
- });
525
+ //bad
526
+ function readPackageJson (callback) {
527
+ fs.readFile(' package .json ' , function (err, file) {
528
+ if (err) {
529
+ throw err;
530
+ }
531
+ ...
532
+ });
533
+ }
534
+ //good
535
+ function readPackageJson (callback) {
536
+ fs.readFile(' package .json ' , function (err, file) {
537
+ if (err) {
538
+ return callback(err);
542
539
}
540
+ ...
541
+ });
542
+ }
543
543
```
544
544
545
545
- Catch errors in sync calls
546
546
547
547
```javascript
548
- //bad
549
- var data = JSON.parse(jsonAsAString);
550
-
551
- //good
552
- var data;
553
- try {
554
- data = JSON.parse(jsonAsAString);
555
- } catch (e) {
556
- //handle error - hopefully not with a console.log ;)
557
- console.log(e);
558
- }
548
+ //bad
549
+ var data = JSON.parse(jsonAsAString);
550
+
551
+ //good
552
+ var data;
553
+ try {
554
+ data = JSON.parse(jsonAsAString);
555
+ } catch (e) {
556
+ //handle error - hopefully not with a console.log ;)
557
+ console.log(e);
558
+ }
559
559
```
560
560
561
561
**[⬆ back to top](#table-of-contents)**
0 commit comments