CSHARP-2295: Deprecate group command helpers

Author: ksadoff

src/MongoDB.Driver.Core/Core/Misc/Feature.cs

@@ -54,7 +54,7 @@ public class Feature
         private static readonly Feature __findAndModifyWriteConcern = new Feature("FindAndModifyWriteConcern", new SemanticVersion(3, 2, 0));
         private static readonly Feature __findCommand = new Feature("FindCommand", new SemanticVersion(3, 2, 0));
         private static readonly Feature __geoNearCommand = new Feature("GeoNearCommand", new SemanticVersion(1, 0, 0), new SemanticVersion(4, 1, 0, ""));
-        private static readonly Feature __groupCommand = new Feature("GroupCommand", new SemanticVersion(1, 0, 0), new SemanticVersion(4, 0, 0, "rc1"));
+        private static readonly Feature __groupCommand = new Feature("GroupCommand", new SemanticVersion(1, 0, 0), new SemanticVersion(4, 1, 1, ""));
         private static readonly Feature __keepConnectionPoolWhenNotMasterConnectionException = new Feature("KeepConnectionPoolWhenNotMasterConnectionException", new SemanticVersion(4, 1, 10));
         private static readonly Feature __keepConnectionPoolWhenReplSetStepDown = new Feature("KeepConnectionPoolWhenReplSetStepDown", new SemanticVersion(4, 1, 10));
         private static readonly Feature __killCursorsCommand = new Feature("KillCursorsCommand", new SemanticVersion(3, 2, 0));

src/MongoDB.Driver.Legacy/MongoCollection.cs

@@ -1201,11 +1201,13 @@ public virtual CollectionStatsResult GetStats(GetStatsArgs args)
         /// </summary>
         /// <param name="args">The args.</param>
         /// <returns>A list of results as BsonDocuments.</returns>
+        [Obsolete("The group command was deprecated in server version 3.4.")]
         public virtual IEnumerable<BsonDocument> Group(GroupArgs args)
         {
             return UsingImplicitSession(session => Group(session, args));
         }
 
+        [Obsolete("The group command was deprecated in server version 3.4.")]
         private IEnumerable<BsonDocument> Group(IClientSessionHandle session, GroupArgs args)
         {
             if (args == null) { throw new ArgumentNullException("args"); }
@@ -1255,6 +1257,7 @@ private IEnumerable<BsonDocument> Group(IClientSessionHandle session, GroupArgs
         /// <param name="reduce">A JavaScript function that is called for each matching document in a group.</param>
         /// <param name="finalize">A JavaScript function that is called at the end of the group command.</param>
         /// <returns>A list of results as BsonDocuments.</returns>
+        [Obsolete("The group command was deprecated in server version 3.4.")]
         public virtual IEnumerable<BsonDocument> Group(
             IMongoQuery query,
             BsonJavaScript keyFunction,
@@ -1281,6 +1284,7 @@ public virtual IEnumerable<BsonDocument> Group(
         /// <param name="reduce">A JavaScript function that is called for each matching document in a group.</param>
         /// <param name="finalize">A JavaScript function that is called at the end of the group command.</param>
         /// <returns>A list of results as BsonDocuments.</returns>
+        [Obsolete("The group command was deprecated in server version 3.4.")]
         public virtual IEnumerable<BsonDocument> Group(
             IMongoQuery query,
             IMongoGroupBy keys,
@@ -1307,6 +1311,7 @@ public virtual IEnumerable<BsonDocument> Group(
         /// <param name="reduce">A JavaScript function that is called for each matching document in a group.</param>
         /// <param name="finalize">A JavaScript function that is called at the end of the group command.</param>
         /// <returns>A list of results as BsonDocuments.</returns>
+        [Obsolete("The group command was deprecated in server version 3.4.")]
         public virtual IEnumerable<BsonDocument> Group(
             IMongoQuery query,
             string key,

tests/MongoDB.Driver.Legacy.Tests/MongoCollectionTests.cs

@@ -892,7 +892,7 @@ public void TestDropIndex()
         public void TestDropIndexWriteConcern()
         {
             RequireServer.Check().Supports(Feature.AggregateOut, Feature.CommandsThatWriteAcceptWriteConcern).ClusterType(ClusterType.ReplicaSet);
-            
+
             _collection.Drop();
             _collection.CreateIndex("x");
             var writeConcern = new WriteConcern(9, wTimeout: TimeSpan.FromMilliseconds(1));
@@ -2073,8 +2073,9 @@ public void TestGroupWithFinalizeFunction()
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
-
+#pragma warning disable 618
             var results = _collection.Group(new GroupArgs
+#pragma warning restore
             {
                 KeyFields = GroupBy.Keys("x"),
                 Initial = new BsonDocument("count", 0),
@@ -2102,8 +2103,9 @@ public void TestGroupWithKeyFields()
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
-
+#pragma warning disable 618
             var results = _collection.Group(new GroupArgs
+#pragma warning restore
             {
                 KeyFields = GroupBy.Keys("x"),
                 Initial = new BsonDocument("count", 0),
@@ -2130,8 +2132,9 @@ public void TestGroupWithKeyFunction()
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
-
+#pragma warning disable 618
             var results = _collection.Group(new GroupArgs
+#pragma warning restore
             {
                 KeyFunction = "function(doc) { return { x : doc.x }; }",
                 Initial = new BsonDocument("count", 0),
@@ -2168,7 +2171,9 @@ public void TestGroupWithMaxTime()
                             ReduceFunction = "function(doc, prev) { prev.count += 1 }",
                             MaxTime = TimeSpan.FromMilliseconds(1)
                         };
+#pragma warning disable 618
                         Assert.Throws<MongoExecutionTimeoutException>(() => _collection.Group(args));
+#pragma warning restore
                     }
                 }
             }
@@ -2185,8 +2190,9 @@ public void TestGroupWithQuery()
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
             _collection.Insert(new BsonDocument("x", 3));
-
+#pragma warning disable 618
             var results = _collection.Group(new GroupArgs
+#pragma warning restore
             {
                 Query = Query.LT("x", 3),
                 KeyFields = GroupBy.Keys("x"),