Skip to content

Commit 16cd5f2

Browse files
Fixed Test case failure in PR 29037 - [2025/04/21] Candidate (#29049)
* Added the base snapshots * Updated Copilot suggestion * Update PhoneFlyoutPageRenderer.cs * Update Issue28536.cs * Update Issue8632.cs
1 parent 1fb5164 commit 16cd5f2

File tree

6 files changed

+4
-4
lines changed

6 files changed

+4
-4
lines changed

src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,7 @@ void LayoutChildren(bool animated)
481481
void UpdateFlyoutLayoutBehaviorChanges()
482482
{
483483
LayoutChildren(true);
484-
FlyoutPage flyoutPage = Element as FlyoutPage;
485-
if (flyoutPage == null)
484+
if (FlyoutPage is null)
486485
return;
487486
FlyoutLayoutBehavior flyoutBehavior = FlyoutPage.FlyoutLayoutBehavior;
488487
bool shouldPresent = FlyoutPageController.ShouldShowSplitMode;
@@ -491,7 +490,7 @@ void UpdateFlyoutLayoutBehaviorChanges()
491490
shouldPresent = false;
492491
}
493492

494-
if (shouldPresent != flyoutPage.IsPresented)
493+
if (shouldPresent != FlyoutPage.IsPresented)
495494
{
496495
((IElementController)Element).SetValueFromRenderer(FlyoutPage.IsPresentedProperty, shouldPresent);
497496
UpdateLeftBarButton();

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28536.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public void CheckNavigationBreaksVisualStatesForPicker()
1818
{
1919
App.WaitForElement("VisualStatePicker");
2020
App.Tap(Switch);
21+
App.WaitForElement("NavigateButton");
2122
App.Tap("NavigateButton");
2223
App.WaitForElement("Next Page");
2324
App.TapBackArrow();

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8632.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#if TEST_FAILS_ON_IOS || TEST_FAILS_ON_CATALYST // https://github.com/dotnet/maui/issues/28910
1+
#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS// https://github.com/dotnet/maui/issues/28910
22
using NUnit.Framework;
33
using UITest.Appium;
44
using UITest.Core;

0 commit comments

Comments
 (0)