[iOS] SwipeView Closes when Content Changes - fix (#29088)

* [iOS] SwipeView Closes when Content Changes - fix

* Added snapshots

Author: kubaflo

src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml

@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+             x:Name="Self"
+             x:Class="Maui.Controls.Sample.Issues.Issue29086">
+    <CollectionView ItemsSource="{Binding Numbers}"
+                    Margin="60">
+        <CollectionView.ItemTemplate>
+            <DataTemplate>
+                <SwipeView>
+                    <SwipeView.LeftItems>
+                        <SwipeItems
+                            Mode="Reveal"
+                            SwipeBehaviorOnInvoked="RemainOpen">
+                            <SwipeItemView>
+                                <Button
+                                    Text="+"
+                                    AutomationId="AddButton"
+                                    WidthRequest="40"
+                                    BackgroundColor="LightGreen"
+                                    Command="{Binding Source={x:Reference Self}, Path=IncrementCommand}"
+                                    CommandParameter="{Binding .}"/>
+                            </SwipeItemView>
+                            <SwipeItemView>
+                                <Button
+                                    Text="-"
+                                    WidthRequest="40"
+                                    BackgroundColor="LightCoral"
+                                    Command="{Binding Source={x:Reference Self}, Path=DecrementCommand}"
+                                    CommandParameter="{Binding .}"/>
+                            </SwipeItemView>
+                        </SwipeItems>
+                    </SwipeView.LeftItems>
+
+                    <Grid Padding="10"
+                          AutomationId="SwipeItem"
+                          BackgroundColor="LightBlue">
+                        <Label Text="{Binding Value}"
+                               FontSize="18"
+                               HorizontalOptions="Center"/>
+                    </Grid>
+                </SwipeView>
+            </DataTemplate>
+        </CollectionView.ItemTemplate>
+    </CollectionView>
+</ContentPage>

src/Controls/tests/TestCases.HostApp/Issues/Issue29086.xaml.cs

@@ -0,0 +1,37 @@
+using System.Collections.ObjectModel;
+using System.Windows.Input;
+
+namespace Maui.Controls.Sample.Issues;
+
+[Issue(IssueTracker.Github, 29086, "SwipeView Closes when Content Changes even with SwipeBehaviorOnInvoked='RemainOpen'", PlatformAffected.iOS)]
+public partial class Issue29086 : ContentPage
+{
+	public ObservableCollection<NumberItem> Numbers { get; set; }
+	public ICommand IncrementCommand { get; }
+	public ICommand DecrementCommand { get; }
+
+	public Issue29086()
+	{
+		InitializeComponent();
+
+		Numbers = new ObservableCollection<NumberItem>
+		{
+			new NumberItem { Value = 1 },
+		};
+
+		IncrementCommand = new Command<NumberItem>((item) => item.Value++);
+		DecrementCommand = new Command<NumberItem>((item) => item.Value--);
+
+		BindingContext = this;
+	}
+
+	public class NumberItem : ViewModelBase
+	{
+		int _value;
+		public int Value
+		{
+			get => _value;
+			set { _value = value; OnPropertyChanged(); }
+		}
+	}
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29086.cs

@@ -0,0 +1,26 @@
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues;
+
+public class Issue29086 : _IssuesUITest
+{
+
+	public Issue29086(TestDevice testDevice) : base(testDevice)
+	{
+	}
+
+	public override string Issue => "SwipeView Closes when Content Changes even with SwipeBehaviorOnInvoked='RemainOpen'";
+
+	[Test]
+	[Category(UITestCategories.SwipeView)]
+	public void SwipeViewShouldNotClose()
+	{
+		App.WaitForElement("SwipeItem");
+		App.SwipeLeftToRight("SwipeItem");
+		App.Click("AddButton");
+		App.Click("AddButton");
+		VerifyScreenshot();
+	}
+}

src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ItemImageSourceShouldBeVisible.png

@@ -80,6 +80,11 @@ public override void LayoutSubviews()
 
 			if (_contentView != null && _contentView.Frame.IsEmpty)
 				_contentView.Frame = Bounds;
+
+			if (_isOpen)
+			{
+				Swipe(animated: false);
+			}
 		}
 
 		public override void TouchesEnded(NSSet touches, UIEvent? evt)
@@ -581,7 +586,7 @@ void Swipe(bool animated = false)
 
 			if (_swipeTransitionMode == SwipeTransitionMode.Reveal)
 			{
-				Animate(swipeAnimationDuration, 0.0, UIViewAnimationOptions.CurveEaseOut, () =>
+				void SetFrame()
 				{
 					switch (_swipeDirection)
 					{
@@ -598,7 +603,16 @@ void Swipe(bool animated = false)
 							_contentView.Frame = new CGRect(_originalBounds.X, _originalBounds.Y + offset, _originalBounds.Width, _originalBounds.Height);
 							break;
 					}
-				}, null);
+				}
+
+				if (animated)
+				{
+					Animate(swipeAnimationDuration, 0.0, UIViewAnimationOptions.CurveEaseOut, SetFrame, null);
+				}
+				else
+				{
+					SetFrame();
+				}
 			}
 
 			if (_swipeTransitionMode == SwipeTransitionMode.Drag)