Refactoring authentications controller

Author: edimossilva

volume/blog-backend/spec/requests/authentication_request_spec.rb

@@ -5,13 +5,9 @@
     let!(:user) { create :user }
 
     context 'When receive matching username and password' do
-      before do
-        post '/auth/login', params: { username: user.username, password: user.password }
-      end
+      before { post '/auth/login', params: { username: user.username, password: user.password } }
 
-      it 'responds :created' do
-        expect(response).to have_http_status(:ok)
-      end
+      it { expect(response).to have_http_status(:ok) }
 
       it "responds with user's username" do
         json_response = JSON.parse(response.body)
@@ -33,30 +29,21 @@
 
     context 'When receive NOT matching username and password' do
       context 'when invalid username and password' do
-        before do
-          post '/auth/login', params: { username: 'invalid username', password: 'invalid passowrd' }
-        end
-        it 'responds :unauthorized' do
-          expect(response).to have_http_status(:unauthorized)
-        end
+        before { post '/auth/login', params: { username: 'invalid username', password: 'invalid passowrd' } }
+
+        it { expect(response).to have_http_status(:unauthorized) }
       end
 
       context 'when valid username and invalid password' do
-        before do
-          post '/auth/login', params: { username: user.username, password: 'invalid passowrd' }
-        end
-        it 'responds :unauthorized' do
-          expect(response).to have_http_status(:unauthorized)
-        end
+        before { post '/auth/login', params: { username: user.username, password: 'invalid passowrd' } }
+
+        it { expect(response).to have_http_status(:unauthorized) }
       end
 
       context 'when invalid username and valid password' do
-        before do
-          post '/auth/login', params: { username: 'invalid username', password: user.password }
-        end
-        it 'responds :unauthorized' do
-          expect(response).to have_http_status(:unauthorized)
-        end
+        before { post '/auth/login', params: { username: 'invalid username', password: user.password } }
+
+        it { expect(response).to have_http_status(:unauthorized) }
       end
     end
   end