Bug in check for existence of Group field dotnet#1372 (dotnet#1377)

malik97160 · Ivanidzo4ka · commit 818723e7ed8f · 2018-10-25T11:04:16.000-07:00
diff --git a/src/Microsoft.ML.LightGBM/LightGbmTrainerBase.cs b/src/Microsoft.ML.LightGBM/LightGbmTrainerBase.cs
@@ -425,7 +425,7 @@ private void GetMetainfo(IChannel ch, FloatLabelCursor.Factory factory,
             bool hasGroup = false;
             if (PredictionKind == PredictionKind.Ranking)
             {
-                ch.Check(factory.Data.Schema != null, "The data for ranking task should have group field.");
+                ch.Check(factory.Data.Schema.Group != null, "The data for ranking task should have group field.");
                 hasGroup = true;
             }
             List<float> weightList = hasWeights ? new List<float>() : null;

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,7 @@ private void GetMetainfo(IChannel ch, FloatLabelCursor.Factory factory,`
`425`	`425`	`bool hasGroup = false;`
`426`	`426`	`if (PredictionKind == PredictionKind.Ranking)`
`427`	`427`	`{`
`428`		`- ch.Check(factory.Data.Schema != null, "The data for ranking task should have group field.");`
	`428`	`+ ch.Check(factory.Data.Schema.Group != null, "The data for ranking task should have group field.");`
`429`	`429`	`hasGroup = true;`
`430`	`430`	`}`
`431`	`431`	`List<float> weightList = hasWeights ? new List<float>() : null;`