Add support for VisualBasicHelper for List literals

Author: lorcQc

EFCore.VisualBasic/Design/Internal/VisualBasicHelper.vb

@@ -26,8 +26,7 @@ Namespace Design.Internal
             _typeMappingSource = typeMappingSource
         End Sub
 
-        Private Shared ReadOnly _literalFuncs As IReadOnlyDictionary(Of Type, Func(Of VisualBasicHelper, Object, String)) =
-        New Dictionary(Of Type, Func(Of VisualBasicHelper, Object, String)) From
+        Private Shared ReadOnly _literalFuncs As New Dictionary(Of Type, Func(Of VisualBasicHelper, Object, String)) From
         {
             {GetType(Boolean), Function(c, v) c.Literal(CBool(v))},
             {GetType(Byte), Function(c, v) c.Literal(CByte(v))},
@@ -578,6 +577,60 @@ Namespace Design.Internal
             Return builder.ToString()
         End Function
 
+        ''' <summary>
+        '''     This API supports the Entity Framework Core infrastructure And Is Not intended to be used
+        '''     directly from your code. This API may change Or be removed in future releases.
+        ''' </summary>
+        Public Overridable Function Literal(Of T)(values As List(Of T), Optional vertical As Boolean = False) As String
+            Return ListLitetal(GetType(T), values, vertical)
+        End Function
+
+        Private Function ListLitetal(type As Type, values As IEnumerable, Optional vertical As Boolean = False) As String
+
+            Dim builder As New IndentedStringBuilder()
+
+            builder.
+                Append("New List(Of ").
+                Append(Reference(type)).
+                Append(")")
+
+            Dim hasData = False
+            Dim first = True
+
+            For Each value In values
+                hasData = True
+                If first Then
+                    builder.Append(" From {")
+                    If vertical Then
+                        builder.AppendLine()
+                        builder.IncrementIndent()
+                    End If
+                    first = False
+                Else
+                    builder.Append(","c)
+
+                    If vertical Then
+                        builder.AppendLine()
+                    Else
+                        builder.Append(" "c)
+                    End If
+                End If
+
+                builder.Append(UnknownLiteral(value))
+            Next
+
+            If hasData Then
+                If vertical Then
+                    builder.AppendLine()
+                    builder.DecrementIndent()
+                End If
+
+                builder.Append("}"c)
+            End If
+
+            Return builder.ToString()
+        End Function
+
         ''' <summary>
         '''     This API supports the Entity Framework Core infrastructure And Is Not intended to be used
         '''     directly from your code. This API may change Or be removed in future releases.
@@ -682,6 +735,13 @@ Namespace Design.Internal
                 Return ArrayLitetal(LiteralType.GetElementType(), DirectCast(value, Array))
             End If
 
+            If TypeOf value Is IList AndAlso
+               value.GetType().IsGenericType AndAlso
+               value.GetType().GetGenericTypeDefinition() Is GetType(List(Of)) Then
+
+                Return ListLitetal(value.GetType().GetGenericArguments()(0), DirectCast(value, IList))
+            End If
+
             Dim mapping = _typeMappingSource.FindMapping(LiteralType)
             If mapping IsNot Nothing Then
                 Dim builder As New StringBuilder

Test/EFCore.VisualBasic.Test/Design/Internal/VisualBasicHelperTests.vb

@@ -123,6 +123,34 @@ Namespace Design.Internal
                     "New Byte() {1, 2}")
         End Sub
 
+        <ConditionalFact>
+        Public Sub Literal_works_when_empty_list()
+            Literal_works(
+            New List(Of String),
+            "New List(Of String)")
+        End Sub
+
+        <ConditionalFact>
+        Public Sub Literal_works_when_list_with_single_element()
+            Literal_works(
+            New List(Of String) From {"one"},
+            "New List(Of String) From {""one""}")
+        End Sub
+
+        <ConditionalFact>
+        Public Sub Literal_works_when_list_of_mixed_objects()
+            Literal_works(
+            New List(Of Object) From {1, "two"},
+            "New List(Of Object) From {1, ""two""}")
+        End Sub
+
+        <ConditionalFact>
+        Public Sub Literal_works_when_list_with_ctor_arguments()
+            Literal_works(
+            New List(Of String)({"one"}) From {"two", "three"},
+            "New List(Of String) From {""one"", ""two"", ""three""}")
+        End Sub
+
         <ConditionalFact>
         Public Sub Literal_works_when_multiline_string()
             Literal_works(
@@ -249,7 +277,24 @@ string with """,
     {""A"", 1},
     {""B"", 2}
 }",
-                    result,
+            result,
+            ignoreLineEndingDifferences:=True)
+        End Sub
+
+        <ConditionalFact>
+        Public Sub Literal_works_when_list_in_vertical()
+
+            Dim listToTest As New List(Of Object) From {New List(Of Integer)({1}), "two", 3}
+
+            Dim result = New VisualBasicHelper(TypeMappingSource).Literal(listToTest, True)
+
+            Assert.Equal(
+"New List(Of Object) From {
+    New List(Of Integer) From {1},
+    ""two"",
+    3
+}",
+            result,
             ignoreLineEndingDifferences:=True)
         End Sub