Skip to content

Commit 3fff2c2

Browse files
author
elgris
committed
fixed InsertBuilder in order, now tests pass
1 parent 7663fcf commit 3fff2c2

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

insert.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,16 +186,16 @@ func (b *InsertBuilder) Suffix(sql string, args ...interface{}) *InsertBuilder {
186186
// note that it will reset all previous columns and values was set if any
187187
func (b *InsertBuilder) SetMap(clauses map[string]interface{}) *InsertBuilder {
188188
// TODO: replace resetting previous values with extending existing ones?
189-
b.columns = make([]string, 0, len(clauses))
190-
b.values = make([][]interface{}, 0, len(clauses))
189+
cols := make([]string, 0, len(clauses))
190+
vals := make([]interface{}, 0, len(clauses))
191191

192192
for col, val := range clauses {
193-
b.columns = append(b.columns, col)
194-
195-
// may panic here
196-
197-
b.values = append(b.values, val.([]interface{}))
193+
cols = append(cols, col)
194+
vals = append(vals, val)
198195
}
199196

197+
b.columns = cols
198+
b.values = [][]interface{}{vals}
199+
200200
return b
201201
}

0 commit comments

Comments
 (0)