Skip to content

Commit 175a1f9

Browse files
authored
Fix sensor list jumping to top on update (home-assistant#706)
Fixes home-assistant#701.
1 parent 13dbb77 commit 175a1f9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

HomeAssistant/Views/Settings/Sensors/SensorListViewController.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,18 +83,20 @@ class SensorListViewController: FormViewController, SensorObserver {
8383
$0.map { Self.row(for: $0) }
8484
}.ensure { [refreshControl] in
8585
refreshControl.endRefreshing()
86-
}.done { [sensorSection] value in
86+
}.done { [tableView, sensorSection] value in
8787
let sinceFormatter = DateFormatter()
8888
sinceFormatter.formattingContext = .middleOfSentence
8989
sinceFormatter.dateStyle = .none
9090
sinceFormatter.timeStyle = .medium
9191

92+
tableView?.beginUpdates()
9293
sensorSection.removeAll()
9394
sensorSection.append(contentsOf: value)
9495
sensorSection.footer = HeaderFooterView(
9596
title: L10n.SettingsSensors.LastUpdated.footer(sinceFormatter.string(from: update.on))
9697
)
97-
sensorSection.reload(with: .none)
98+
sensorSection.reload()
99+
tableView?.endUpdates()
98100
}.catch { error in
99101
let alert = UIAlertController(
100102
title: L10n.SettingsSensors.LoadingError.title,

0 commit comments

Comments
 (0)