Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qemu/qemu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ekoeppen/qemu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 17 files changed
  • 2 contributors

Commits on Feb 10, 2013

  1. target-arm: Clear thumb state bit when popping PC during ARMV7M inter… 

    …rupt exit

An operating system (e.g. FreeRTOS) may create a task by setting up a stack
with a "simulated" stack frame containing the start address of the task.
The OS will then start the task by switching to the stack and doing an
interrupt return from within the service handler.  If the start address is a
function pointer, its thumb state bit (bit 0) will contain a 1 to indicate
the first instruction is a thumb instruction (and in the ARMV7M architecture,
all instructions are thumb instructions).  When the interrupt returns,
QEMU will pop the start address into the PC register.  QEMU expects the
PC register to be half-word aligned (which is enforced when branching),
and will not run properly when the PC is odd.

This patch clears bit 0 when restoring the PC during the ARMV7M interrupt exit.

Note that there is a bug open against QEMU for this problem:
https://bugs.launchpad.net/qemu/+bug/657006
    @beckus @ekoeppen
    beckus authored and ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    0704593 View commit details
    Browse the repository at this point in the history

  2. hw/armv7m_nvic: Implement byte read/write for ARMV7M SCB_SHPRx registers 

    Adds nvic_writeb and nvic_readb functions.

Implements byte read/write for the ARMV7M SCB_SHPRx (System Handler
Priority Registers).  Currently, only double word access is implemented.
The ARM CMSIS library maps these registers to a byte array, which requires that
byte access be implemented.

Note that because the NVIC ID register read handles both byte and word reads,
it is left as-is, and not moved into the new nvic_readb function.

Conflicts:
	hw/armv7m_nvic.c
    @beckus @ekoeppen
    beckus authored and ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    3880b7c View commit details
    Browse the repository at this point in the history

  3. hw/armv7m_nvic: Add global variable for SysTick external reference clock 

    Adds a new external reference clock scale variable to complement the existing
system_clock_scale variable.  Previously, the value was hardcoded to 1000
when calculating the SysTick scale.  The new variable defaults to 1000 to
maintain backward compatibility.
    @beckus @ekoeppen
    beckus authored and ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    070c649 View commit details
    Browse the repository at this point in the history

  4. Add STM32 implementation

    @beckus @ekoeppen
    beckus authored and ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    b93f9dc View commit details
    Browse the repository at this point in the history

  5. Cleaned up Clock Tree comments.

    @beckus @ekoeppen
    beckus authored and ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    d17043c View commit details
    Browse the repository at this point in the history

  6. Fix include paths for renamed files

    @ekoeppen
    ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    a21890f View commit details
    Browse the repository at this point in the history

  7. Followed renaming of target_phys_addr_t to hwaddr

    @ekoeppen
    ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    59ed178 View commit details
    Browse the repository at this point in the history

  8. Follow move of cpu_index field to CPUState

    @ekoeppen
    ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    9bf9538 View commit details
    Browse the repository at this point in the history

  9. Fix include file moves

    @ekoeppen
    ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    27fabc4 View commit details
    Browse the repository at this point in the history

  10. Add clktree.c to Makefile

    @ekoeppen
    ekoeppen committed Feb 10, 2013
    Configuration menu
    Copy the full SHA
    50faf60 View commit details
    Browse the repository at this point in the history
Loading