Skip to content

ESQL: Don't build empty ValuesSourceReaderOperators #130727

Closed
@nik9000

Description

@nik9000

Description

In ESQL ValuesSourceReaderOperator is the rather anachronistic name of the Operator that reads doc values and stored fields from the lucene index. I'm working on it now to split pages in #130573. I've found out that we sometimes create a ValuesSourceReaderOperator when telling it to load 0 fields. This is redundant. And adds complexity to the code:

                // TODO this is needed when we load 0 fields. Can we just skip building the Operator at all in that case?

Let's fix it!

We could assert in the factory that the list of fields we're loading is non-empty.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions