Skip to content

Commit 144f0aa

Browse files
committed
Closes ECSlidingViewController#244 Give custom layouts top view position
1 parent 6c7fdf8 commit 144f0aa

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

ECSlidingViewController/ECSlidingViewController.m

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ @interface ECSlidingViewController()
4949
- (void)setup;
5050

5151
- (CGRect)topViewCalculatedFrameForPosition:(ECSlidingViewControllerTopViewPosition)position;
52-
- (CGRect)underLeftViewCalculatedFrame;
53-
- (CGRect)underRightViewCalculatedFrame;
52+
- (CGRect)underLeftViewCalculatedFrameForTopViewPosition:(ECSlidingViewControllerTopViewPosition)position;
53+
- (CGRect)underRightViewCalculatedFrameTopViewPosition:(ECSlidingViewControllerTopViewPosition)position;
5454
- (CGRect)frameFromDelegateForViewController:(UIViewController *)viewController
5555
topViewPosition:(ECSlidingViewControllerTopViewPosition)topViewPosition;
5656
- (ECSlidingViewControllerOperation)operationFromPosition:(ECSlidingViewControllerTopViewPosition)fromPosition
@@ -178,8 +178,8 @@ - (void)viewDidLayoutSubviews {
178178
if (self.currentOperation == ECSlidingViewControllerOperationNone) {
179179
self.gestureView.frame = [self topViewCalculatedFrameForPosition:self.currentTopViewPosition];
180180
self.topViewController.view.frame = [self topViewCalculatedFrameForPosition:self.currentTopViewPosition];
181-
self.underLeftViewController.view.frame = [self underLeftViewCalculatedFrame];
182-
self.underRightViewController.view.frame = [self underRightViewCalculatedFrame];
181+
self.underLeftViewController.view.frame = [self underLeftViewCalculatedFrameTopViewPosition:self.currentTopViewPosition];
182+
self.underRightViewController.view.frame = [self underRightViewCalculatedFrameTopViewPosition:self.currentTopViewPosition];
183183
}
184184
}
185185

@@ -470,9 +470,9 @@ - (CGRect)topViewCalculatedFrameForPosition:(ECSlidingViewControllerTopViewPosit
470470
}
471471
}
472472

473-
- (CGRect)underLeftViewCalculatedFrame {
473+
- (CGRect)underLeftViewCalculatedFrameTopViewPosition:(ECSlidingViewControllerTopViewPosition)position {
474474
CGRect frameFromDelegate = [self frameFromDelegateForViewController:self.underLeftViewController
475-
topViewPosition:self.currentTopViewPosition];
475+
topViewPosition:position];
476476
if (!CGRectIsInfinite(frameFromDelegate)) return frameFromDelegate;
477477

478478
CGRect containerViewFrame = self.view.bounds;
@@ -495,9 +495,9 @@ - (CGRect)underLeftViewCalculatedFrame {
495495
return containerViewFrame;
496496
}
497497

498-
- (CGRect)underRightViewCalculatedFrame {
498+
- (CGRect)underRightViewCalculatedFrameTopViewPosition:(ECSlidingViewControllerTopViewPosition)position {
499499
CGRect frameFromDelegate = [self frameFromDelegateForViewController:self.underRightViewController
500-
topViewPosition:self.currentTopViewPosition];
500+
topViewPosition:position];
501501
if (!CGRectIsInfinite(frameFromDelegate)) return frameFromDelegate;
502502

503503
CGRect containerViewFrame = self.view.bounds;
@@ -880,10 +880,10 @@ - (CGRect)initialFrameForViewController:(UIViewController *)vc {
880880
if ([vc isEqual:self.topViewController]) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionCentered];
881881
} else if (self.currentOperation == ECSlidingViewControllerOperationResetFromLeft) {
882882
if ([vc isEqual:self.topViewController]) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionAnchoredLeft];
883-
if ([vc isEqual:self.underRightViewController]) return [self underRightViewCalculatedFrame];
883+
if ([vc isEqual:self.underRightViewController]) return [self underRightViewCalculatedFrameTopViewPosition:ECSlidingViewControllerTopViewPositionAnchoredLeft];
884884
} else if (self.currentOperation == ECSlidingViewControllerOperationResetFromRight) {
885885
if ([vc isEqual:self.topViewController]) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionAnchoredRight];
886-
if ([vc isEqual:self.underLeftViewController]) return [self underLeftViewCalculatedFrame];
886+
if ([vc isEqual:self.underLeftViewController]) return [self underLeftViewCalculatedFrameTopViewPosition:ECSlidingViewControllerTopViewPositionAnchoredRight];
887887
}
888888

889889
return CGRectZero;
@@ -892,10 +892,10 @@ - (CGRect)initialFrameForViewController:(UIViewController *)vc {
892892
- (CGRect)finalFrameForViewController:(UIViewController *)vc {
893893
if (self.currentOperation == ECSlidingViewControllerOperationAnchorLeft) {
894894
if (vc == self.topViewController) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionAnchoredLeft];
895-
if (vc == self.underRightViewController) return [self underRightViewCalculatedFrame];
895+
if (vc == self.underRightViewController) return [self underRightViewCalculatedFrameTopViewPosition:ECSlidingViewControllerTopViewPositionAnchoredLeft];
896896
} else if (self.currentOperation == ECSlidingViewControllerOperationAnchorRight) {
897897
if (vc == self.topViewController) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionAnchoredRight];
898-
if (vc == self.underLeftViewController) return [self underLeftViewCalculatedFrame];
898+
if (vc == self.underLeftViewController) return [self underLeftViewCalculatedFrameTopViewPosition:ECSlidingViewControllerTopViewPositionAnchoredRight];
899899
} else if (self.currentOperation == ECSlidingViewControllerOperationResetFromLeft) {
900900
if (vc == self.topViewController) return [self topViewCalculatedFrameForPosition:ECSlidingViewControllerTopViewPositionCentered];
901901
} else if (self.currentOperation == ECSlidingViewControllerOperationResetFromRight) {

Examples/TransitionFun/TransitionFun/Base.lproj/Main.storyboard

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="4514" systemVersion="13A3017" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" initialViewController="vXZ-lx-hvc">
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="4514" systemVersion="13B3116" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" initialViewController="vXZ-lx-hvc">
33
<dependencies>
44
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="3747"/>
55
</dependencies>

0 commit comments

Comments
 (0)