Wrong identity object in schema in getting started guide of schema-record

[Jopie01]

I upgraded my packages from 5.4.0-alpha.120 to 5.6.0-alpha.2 and walked into a problem with the schema-record package. I got the error Expected a resource schema and didn't know where it came from. So I digged into the code and found the change at https://github.com/emberjs/data/blob/245ba3cde61cb0690ba7f13739c3b03e5af2e193/packages/schema-record/src/-private/hooks.ts#L17C11-L17C37. As it seems there is now a test to check if the identifier is really a schema.

Looking at

data/packages/core-types/src/schema/fields.ts

Line 2063 in 100a5eb

export function isResourceSchema(schema: ResourceSchema | ObjectSchema): schema is ResourceSchema {

where the check is defined, I saw that it looks for a key called kind in the identity object. So I added that data and everything worked again.

However, looking into the getting started guide

data/packages/schema-record/README.md

Line 126 in 245ba3c

identity: { type: '@id', name: 'id' },

I see that there is not a kind key but a type. Shouldn't be that kind as well? Otherwise you will get the same error as I had.

[runspired]

not sure how you got by without kind before but yes the readme there has the wrong thing, will fix, thanks!

[Jopie01]

not sure how you got by without kind before

That's easy to explain: The check is added in PR #9757 and since 5.4.0-alpha.144. I came from 5.4.0-alpha.120 and the id field was a derived field in my schema so I had to change it.