Skip to content

Commit 2482fc7

Browse files
emyarodjoshblack
authored andcommitted
feat(FileUploader): Add optional name attribute for FileUploader (carbon-design-system#974)
* feat(FileUploader): Add optional `name` attribute for FileUploader * fix(FileUploader): Remove default `name` attribute on `input[type="file"]` * docs(FileUploader): Add name attribute to FileUploaderButton
1 parent 5f948a9 commit 2482fc7

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/components/FileUploader/FileUploader-story.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ storiesOf('FileUploader', module)
1616
<FileUploaderButton
1717
labelText="Add files"
1818
className="bob"
19+
name="file"
1920
onChange={() => console.log('hi')}
2021
multiple
2122
/>
@@ -34,6 +35,7 @@ storiesOf('FileUploader', module)
3435
buttonLabel="Add files"
3536
filenameStatus="edit"
3637
accept={['.jpg', '.png']}
38+
name="file"
3739
multiple
3840
ref={fileUploader => (this.fileUploader = fileUploader)}
3941
/>

src/components/FileUploader/FileUploader.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export class FileUploaderButton extends Component {
1313
labelText: PropTypes.string,
1414
listFiles: PropTypes.bool,
1515
multiple: PropTypes.bool,
16+
name: PropTypes.string,
1617
onChange: PropTypes.func,
1718
onClick: PropTypes.func,
1819
role: PropTypes.string,
@@ -65,6 +66,7 @@ export class FileUploaderButton extends Component {
6566
tabIndex,
6667
buttonKind,
6768
accept,
69+
name,
6870
...other
6971
} = this.props;
7072
const classes = classNames({
@@ -96,6 +98,7 @@ export class FileUploaderButton extends Component {
9698
type="file"
9799
multiple={multiple}
98100
accept={accept}
101+
name={name}
99102
onChange={this.handleChange}
100103
onClick={evt => {
101104
evt.target.value = null;
@@ -171,6 +174,7 @@ export default class FileUploader extends Component {
171174
labelDescription: PropTypes.string,
172175
labelTitle: PropTypes.string,
173176
multiple: PropTypes.bool,
177+
name: PropTypes.string,
174178
onChange: PropTypes.func,
175179
onClick: PropTypes.func,
176180
className: PropTypes.string,
@@ -229,6 +233,7 @@ export default class FileUploader extends Component {
229233
className,
230234
multiple,
231235
accept,
236+
name,
232237
...other
233238
} = this.props;
234239

@@ -248,6 +253,7 @@ export default class FileUploader extends Component {
248253
onChange={this.handleChange}
249254
disableLabelChanges
250255
accept={accept}
256+
name={name}
251257
/>
252258
<div className="bx--file-container">
253259
{this.state.filenames.length === 0

0 commit comments

Comments
 (0)